From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v5 4/4] lavc: implement a Vulkan-based VC-2 encoder Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths.
Date: Mon, 26 May 2025 03:30:48 +0200
Message-ID: <20250526013048.GP29660@pb2> (raw)
In-Reply-To: <20250523202351.1712778-4-47210458+raphaelthegreat@users.noreply.github.com>
[-- Attachment #1.1: Type: text/plain, Size: 2540 bytes --]
On Fri, May 23, 2025 at 11:23:48PM +0300, IndecisiveTurtle wrote:
> From: IndecisiveTurtle <geoster3d@gmail.com>
>
> Performance wise, encoding a 3440x1440 1-minute video is performed in about 2.4 minutes with the cpu encoder running on my Ryzen 5 4600H, while it takes about 1.3 minutes on my NVIDIA GTX 1650
>
> Haar shader has a subgroup optimized variant that applies when configured wavelet depth allows it
> ---
> configure | 1 +
> libavcodec/Makefile | 3 +
> libavcodec/allcodecs.c | 1 +
> libavcodec/vc2enc.c | 2 +-
> libavcodec/vc2enc_vulkan.c | 777 +++++++++++++++++++
> libavcodec/vulkan/vc2_dwt_haar.comp | 82 ++
> libavcodec/vulkan/vc2_dwt_haar_subgroup.comp | 75 ++
> libavcodec/vulkan/vc2_dwt_hor_legall.comp | 82 ++
> libavcodec/vulkan/vc2_dwt_upload.comp | 96 +++
> libavcodec/vulkan/vc2_dwt_ver_legall.comp | 78 ++
> libavcodec/vulkan/vc2_encode.comp | 173 +++++
> libavcodec/vulkan/vc2_slice_sizes.comp | 170 ++++
> 12 files changed, 1539 insertions(+), 1 deletion(-)
> create mode 100644 libavcodec/vc2enc_vulkan.c
> create mode 100644 libavcodec/vulkan/vc2_dwt_haar.comp
> create mode 100644 libavcodec/vulkan/vc2_dwt_haar_subgroup.comp
> create mode 100644 libavcodec/vulkan/vc2_dwt_hor_legall.comp
> create mode 100644 libavcodec/vulkan/vc2_dwt_upload.comp
> create mode 100644 libavcodec/vulkan/vc2_dwt_ver_legall.comp
> create mode 100644 libavcodec/vulkan/vc2_encode.comp
> create mode 100644 libavcodec/vulkan/vc2_slice_sizes.comp
changes fate results:
--- ./tests/ref/vsynth/vsynth1-vc2-420p 2025-05-23 14:14:31.544448136 +0200
+++ tests/data/fate/vsynth1-vc2-420p 2025-05-26 00:35:09.596187444 +0200
@@ -1,4 +1,4 @@
-74df65b15463f098587d8c09d87286a1 *tests/data/fate/vsynth1-vc2-420p.mov
-1155415 tests/data/fate/vsynth1-vc2-420p.mov
+bea01eb2c6212e8828802fdb28dc7eaf *tests/data/fate/vsynth1-vc2-420p.mov
+1045964 tests/data/fate/vsynth1-vc2-420p.mov
387696707c79cf1a6c9aeff4024226b9 *tests/data/fate/vsynth1-vc2-420p.out.rawvideo
stddev: 0.00 PSNR:999.99 MAXDIFF: 0 bytes: 7603200/ 760320
Test vsynth1-vc2-420p failed. Look at tests/data/fate/vsynth1-vc2-420p.err for details.
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-05-26 1:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 20:23 [FFmpeg-devel] [PATCH v5 1/4] libavcodec/vc2enc: Split out common functions between software and hardware encoders IndecisiveTurtle
2025-05-23 20:23 ` [FFmpeg-devel] [PATCH v5 2/4] libavcodec/vc2enc: Switch quant to int IndecisiveTurtle
2025-05-23 20:23 ` [FFmpeg-devel] [PATCH v5 3/4] libavcodec/vulkan: Add modifications to common shader for VC2 vulkan encoder IndecisiveTurtle
2025-05-23 20:23 ` [FFmpeg-devel] [PATCH v5 4/4] lavc: implement a Vulkan-based VC-2 encoder Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths IndecisiveTurtle
2025-05-24 11:09 ` Andreas Rheinhardt
2025-05-24 11:28 ` IndecisiveTurtle
2025-05-26 1:30 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250526013048.GP29660@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git