From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 16D394C413 for ; Sat, 24 May 2025 18:09:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 69A7068DE34; Sat, 24 May 2025 21:09:09 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 3350F68DE25 for ; Sat, 24 May 2025 21:09:07 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3886243A1C for ; Sat, 24 May 2025 18:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1748110147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=18s9VTMNasyuN5sG0Mo7d3UyG2jol9FdXGZ/JZQGZnQ=; b=mjaFa5bciYA6+TB1q6gVd2e4Fprthh/UmhhhixigVo5nJBzAxjA/JIfwjmi9QnIdPiPML+ agpY+SzPcaPEzdZZFTZRKVJvdxYEKpwTn5SJfghMZ+zC9wxnHHAw70jXhWgOUc6DcsZPlz FW0XwVq3ONDS1YY+mqFKo7l72/4ZzTSM0Ctc5bNmHbYkmo65YyZ77jV/3mPBiT/exRXyZX s9IA+2B8upq89SJycEACUMOm/PQDRe7WVcBq/dto31uuUPYmQ9207k/aUpdArYTorGEl2h 1u7SrjTPqCLkuuvCzWSpnuVHvIPv6XR+kR7w+unfRCfuEimJZMMwjSw23BWlsw== Date: Sat, 24 May 2025 20:09:05 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250524180905.GK29660@pb2> References: <20250522214659.252011-1-dev@lynne.ee> MIME-Version: 1.0 In-Reply-To: <20250522214659.252011-1-dev@lynne.ee> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdduvdegtdculddtuddrgeefvddrtddtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] aacdec_ac: fix signed overflow in ff_aac_ac_update_context() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8047688643167909470==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8047688643167909470== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="L3Y4E/NjQRvmPTLz" Content-Disposition: inline --L3Y4E/NjQRvmPTLz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 23, 2025 at 06:46:53AM +0900, Lynne wrote: > The issue is that state->cur[] is 8-bits, but a+b+1 can overflow > before being clipped to 0xF in the following line, causing an incorrect > state to be saved for the next symbol. >=20 > This solves numerous bitstream desyncs, particularly when coefficients > with magnitude greater than 127 are sent. > --- > libavcodec/aac/aacdec_ac.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) LGTM thx --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form of government in which you can choose your dictator --L3Y4E/NjQRvmPTLz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaDILPgAKCRBhHseHBAsP q36TAJoC7JmixO/ZHFkifBO18conK6AAMgCfUrdsjmgS3pUlEnLvMrEKrVqcY8k= =1BOj -----END PGP SIGNATURE----- --L3Y4E/NjQRvmPTLz-- --===============8047688643167909470== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8047688643167909470==--