From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v7 3/4] ogg/vorbis: implement header packet skip in chained ogg bitstreams.
Date: Sat, 24 May 2025 02:40:31 +0200
Message-ID: <20250524004031.GI29660@pb2> (raw)
In-Reply-To: <20250521220538.16624-4-romain.beauxis@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2286 bytes --]
Hi Romain
On Wed, May 21, 2025 at 05:05:37PM -0500, Romain Beauxis wrote:
> ---
> libavcodec/vorbis_parser.h | 11 ++++
> libavcodec/vorbisdec.c | 75 +++++++++++++---------
> libavformat/oggparsevorbis.c | 63 +++++++++++++++++-
> tests/ref/fate/ogg-vorbis-chained-meta.txt | 3 -
> 4 files changed, 115 insertions(+), 37 deletions(-)
make -j32 libavformat/tests/seek && libavformat/tests/seek ~/tickets/2739/lavf_ogm_seeking_borked.ogm
CC libavcodec/libvorbisenc.o
CC libavcodec/version.o
CC libavcodec/vorbis_parser.o
CC libavcodec/vorbisdec.o
CC libswresample/version.o
CC libavutil/version.o
CC libavformat/oggparsevorbis.o
CC libavformat/version.o
AR libswresample/libswresample.a
AR libavutil/libavutil.a
AR libavcodec/libavcodec.a
AR libavformat/libavformat.a
LD libavformat/tests/seek
[ogg @ 0x558349c4f3c0] Headers mismatch for stream 1: expected 3 received 2.
[ogg @ 0x558349c4f3c0] Headers mismatch for stream 2: expected 3 received 2.
ret: 0 st: 0 flags:1 dts:-0.083417 pts: 0.000000 pos: 887 size: 3347
ret: 0 st:-1 flags:0 ts:-1.000000
ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 887 size: 3347
ret: 0 st:-1 flags:1 ts: 1.894167
ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 887 size: 3347
ret: 0 st: 0 flags:0 ts: 0.792458
ret: 0 st: 1 flags:1 dts: 12.481333 pts: 12.481333 pos:2855209 size: 269
ret: 0 st: 0 flags:1 ts:-0.333666
ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 887 size: 3347
ret: 0 st: 1 flags:0 ts: 2.576667
ret: 0 st: 1 flags:1 dts: 2.785333 pts: 2.785333 pos: 559697 size: 255
ret: 0 st: 1 flags:1 ts: 1.470833
ret: 0 st: 1 flags:1 dts: 1.164000 pts: 1.164000 pos: 192278 size: 275
ret: 0 st: 2 flags:0 ts: 0.365000
ret: 0 st: 2 flags:1 dts: 0.332000 pts: 0.332000 pos: 18959 size: 271
Segmentation fault (core dumped)
on samples server: ffmpeg-bugs/trac/ticket2739/lavf_ogm_seeking_borked.ogm
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The worst form of inequality is to try to make unequal things equal.
-- Aristotle
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-24 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 22:05 [FFmpeg-devel] [PATCH v7 0/4] Remove chained ogg stream header packets from the demuxer Romain Beauxis
2025-05-21 22:05 ` [FFmpeg-devel] [PATCH v7 1/4] libavformat/oggdec.{c, h}: Add new_extradata, use it to pass extradata to the next decoded packet Romain Beauxis
2025-05-21 22:05 ` [FFmpeg-devel] [PATCH v7 2/4] ogg/vorbis: factor out header processing logic Romain Beauxis
2025-05-21 22:05 ` [FFmpeg-devel] [PATCH v7 3/4] ogg/vorbis: implement header packet skip in chained ogg bitstreams Romain Beauxis
2025-05-24 0:40 ` Michael Niedermayer [this message]
2025-05-24 18:08 ` Romain Beauxis
2025-05-25 20:25 ` Michael Niedermayer
2025-05-21 22:05 ` [FFmpeg-devel] [PATCH v7 4/4] libavformat/oggdec.h: Change paket function documentation to return 1 on header packets only Romain Beauxis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250524004031.GI29660@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git