* [FFmpeg-devel] [PATCH] avformat/sdp: add framerate entry
@ 2025-05-23 0:11 Marvin Scholz
2025-05-23 18:53 ` Michael Niedermayer
0 siblings, 1 reply; 3+ messages in thread
From: Marvin Scholz @ 2025-05-23 0:11 UTC (permalink / raw)
To: ffmpeg-devel
---
libavformat/sdp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/sdp.c b/libavformat/sdp.c
index 215e38f8fc..21ada5d1ce 100644
--- a/libavformat/sdp.c
+++ b/libavformat/sdp.c
@@ -867,6 +867,9 @@ int ff_sdp_write_media(char *buff, int size, const AVStream *st, int idx,
if (p->bit_rate) {
av_strlcatf(buff, size, "b=AS:%"PRId64"\r\n", p->bit_rate / 1000);
}
+ if (p->framerate.num > 0 && p->framerate.den > 0) {
+ av_strlcatf(buff, size, "a=framerate:%g\r\n", av_q2d(p->framerate));
+ }
return sdp_write_media_attributes(buff, size, st, payload_type, fmt);
}
--
2.39.5 (Apple Git-154)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/sdp: add framerate entry
2025-05-23 0:11 [FFmpeg-devel] [PATCH] avformat/sdp: add framerate entry Marvin Scholz
@ 2025-05-23 18:53 ` Michael Niedermayer
2025-05-23 20:23 ` Marvin Scholz
0 siblings, 1 reply; 3+ messages in thread
From: Michael Niedermayer @ 2025-05-23 18:53 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1709 bytes --]
Hi Marvin
On Fri, May 23, 2025 at 02:11:24AM +0200, Marvin Scholz wrote:
> ---
> libavformat/sdp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavformat/sdp.c b/libavformat/sdp.c
> index 215e38f8fc..21ada5d1ce 100644
> --- a/libavformat/sdp.c
> +++ b/libavformat/sdp.c
> @@ -867,6 +867,9 @@ int ff_sdp_write_media(char *buff, int size, const AVStream *st, int idx,
> if (p->bit_rate) {
> av_strlcatf(buff, size, "b=AS:%"PRId64"\r\n", p->bit_rate / 1000);
> }
> + if (p->framerate.num > 0 && p->framerate.den > 0) {
> + av_strlcatf(buff, size, "a=framerate:%g\r\n", av_q2d(p->framerate));
> + }
>
> return sdp_write_media_attributes(buff, size, st, payload_type, fmt);
> }
> --
> 2.39.5 (Apple Git-154)
breaks fate:
TEST lavf-mov_rtphint
--- ./tests/ref/lavf/mov_rtphint 2025-05-23 14:14:31.476447585 +0200
+++ tests/data/fate/lavf-mov_rtphint 2025-05-23 20:51:14.221038582 +0200
@@ -1,3 +1,3 @@
-d3d0b0a15e2207e1d69b7de5c0ff845c *tests/data/lavf/lavf.mov_rtphint
-365745 tests/data/lavf/lavf.mov_rtphint
+e5e994cd3885a28304229f5e277c1917 *tests/data/lavf/lavf.mov_rtphint
+365761 tests/data/lavf/lavf.mov_rtphint
tests/data/lavf/lavf.mov_rtphint CRC=0xbb2b949b
Test lavf-mov_rtphint failed. Look at tests/data/fate/lavf-mov_rtphint.err for details.
make: *** [tests/Makefile:316: fate-lavf-mov_rtphint] Error 1
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/sdp: add framerate entry
2025-05-23 18:53 ` Michael Niedermayer
@ 2025-05-23 20:23 ` Marvin Scholz
0 siblings, 0 replies; 3+ messages in thread
From: Marvin Scholz @ 2025-05-23 20:23 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On 23 May 2025, at 20:53, Michael Niedermayer wrote:
> Hi Marvin
>
> On Fri, May 23, 2025 at 02:11:24AM +0200, Marvin Scholz wrote:
>> ---
>> libavformat/sdp.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/libavformat/sdp.c b/libavformat/sdp.c
>> index 215e38f8fc..21ada5d1ce 100644
>> --- a/libavformat/sdp.c
>> +++ b/libavformat/sdp.c
>> @@ -867,6 +867,9 @@ int ff_sdp_write_media(char *buff, int size, const AVStream *st, int idx,
>> if (p->bit_rate) {
>> av_strlcatf(buff, size, "b=AS:%"PRId64"\r\n", p->bit_rate / 1000);
>> }
>> + if (p->framerate.num > 0 && p->framerate.den > 0) {
>> + av_strlcatf(buff, size, "a=framerate:%g\r\n", av_q2d(p->framerate));
>> + }
>>
>> return sdp_write_media_attributes(buff, size, st, payload_type, fmt);
>> }
>> --
>> 2.39.5 (Apple Git-154)
>
> breaks fate:
>
> TEST lavf-mov_rtphint
> --- ./tests/ref/lavf/mov_rtphint 2025-05-23 14:14:31.476447585 +0200
> +++ tests/data/fate/lavf-mov_rtphint 2025-05-23 20:51:14.221038582 +0200
> @@ -1,3 +1,3 @@
> -d3d0b0a15e2207e1d69b7de5c0ff845c *tests/data/lavf/lavf.mov_rtphint
> -365745 tests/data/lavf/lavf.mov_rtphint
> +e5e994cd3885a28304229f5e277c1917 *tests/data/lavf/lavf.mov_rtphint
> +365761 tests/data/lavf/lavf.mov_rtphint
> tests/data/lavf/lavf.mov_rtphint CRC=0xbb2b949b
> Test lavf-mov_rtphint failed. Look at tests/data/fate/lavf-mov_rtphint.err for details.
> make: *** [tests/Makefile:316: fate-lavf-mov_rtphint] Error 1
>
Indeed it changed because it includes the SDP. Sent a new version that updates the
ref accordingly.
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Many that live deserve death. And some that die deserve life. Can you give
> it to them? Then do not be too eager to deal out death in judgement. For
> even the very wise cannot see all ends. -- Gandalf
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-23 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-23 0:11 [FFmpeg-devel] [PATCH] avformat/sdp: add framerate entry Marvin Scholz
2025-05-23 18:53 ` Michael Niedermayer
2025-05-23 20:23 ` Marvin Scholz
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git