Re: [FFmpeg-devel] [PATCH v2 08/17] swscale/ops_internal: add internal ops backend API

[Niklas Haas <ffmpeg@haasn.xyz>]

On Fri, 23 May 2025 18:27:38 +0200 Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Wed, May 21, 2025 at 02:43:54PM +0200, Niklas Haas wrote:
> > From: Niklas Haas <git@haasn.dev>
> >
> > This adds an internal API for ops backends, which are responsible for
> > compiling op lists into executable functions.
> > ---
> >  libswscale/ops.c          |  62 ++++++++++++++++++++++
> >  libswscale/ops_internal.h | 108 ++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 170 insertions(+)
> >  create mode 100644 libswscale/ops_internal.h
>
> ubuntu x86-32
>
> In file included from src/libavutil/internal.h:39:0,
>                  from src/libavutil/common.h:50,
>                  from src/libavutil/avutil.h:300,
>                  from src/libswscale/swscale.h:33,
>                  from src/libswscale/graph.h:27,
>                  from src/libswscale/ops.h:28,
>                  from src/libswscale/ops.c:27:
> src/libswscale/ops_internal.h:50:1: error: static assertion failed: "SwsOpExec layout mismatch"
>  static_assert(sizeof(SwsOpExec) == 16 * sizeof(void *) + 8 * sizeof(int32_t),
>  ^
> make: *** [/home/michael/ffmpeg-git/ffmpeg/ffbuild/common.mak:81: libswscale/ops.o] Error 1
> make: *** Waiting for unfinished jobs....

Fixed; I've opted to instead move the alignment to the usage site.

> AR	libavcodec/libavcodec.a
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> While the State exists there can be no freedom; when there is freedom there
> will be no State. -- Vladimir Lenin
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".