From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 5D9954C12C
	for <ffmpegdev@gitmailbox.com>; Fri, 23 May 2025 12:15:06 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3A21768DF45;
	Fri, 23 May 2025 15:15:03 +0300 (EEST)
Received: from haasn.dev (haasn.dev [78.46.187.166])
 by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 054F668DF38
 for <ffmpeg-devel@ffmpeg.org>; Fri, 23 May 2025 15:14:57 +0300 (EEST)
Received: from haasn.dev (unknown [10.30.1.1])
 by haasn.dev (Postfix) with UTF8SMTP id D48FE418EF
 for <ffmpeg-devel@ffmpeg.org>; Fri, 23 May 2025 14:14:56 +0200 (CEST)
Date: Fri, 23 May 2025 14:14:56 +0200
Message-ID: <20250523141456.GE21491@haasn.xyz>
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <f689211b-61b5-4e54-a3a2-5d6a50f2c802@lynne.ee>
References: <20250518121152.94947-1-ffmpeg@haasn.xyz>
 <20250518121152.94947-3-ffmpeg@haasn.xyz>
 <f689211b-61b5-4e54-a3a2-5d6a50f2c802@lynne.ee>
MIME-Version: 1.0
Content-Disposition: inline
Subject: Re: [FFmpeg-devel] [PATCH 3/7] avfilter/vf_gblur_vulkan: omit
 unnecessary buffer usage flag
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250523141456.GE21491@haasn.xyz/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Thu, 22 May 2025 06:32:42 +0900 Lynne <dev@lynne.ee> wrote:
> On 18/05/2025 21:11, Niklas Haas wrote:
> > From: Niklas Haas <git@haasn.dev>
> >
> > Implied internally now when needed.
> > ---
> >   libavfilter/vf_gblur_vulkan.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/libavfilter/vf_gblur_vulkan.c b/libavfilter/vf_gblur_vulkan.c
> > index 80b66de735..fb676a7fc9 100644
> > --- a/libavfilter/vf_gblur_vulkan.c
> > +++ b/libavfilter/vf_gblur_vulkan.c
> > @@ -171,7 +171,6 @@ static int init_gblur_pipeline(GBlurVulkanContext *s,
> >       RET(ff_vk_shader_register_exec(&s->vkctx, &s->e, shd));
> >
> >       RET(ff_vk_create_buf(&s->vkctx, params_buf, sizeof(float) * ksize, NULL, NULL,
> > -                         VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT |
> >                            VK_BUFFER_USAGE_STORAGE_BUFFER_BIT,
> >                            VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT));
> >       RET(ff_vk_map_buffer(&s->vkctx, params_buf, &kernel_mapped, 0));
>
> Its used in a lot more places than here, but its a start.

For the other use cases, I was not sure whether the code itself was taking
the buffer's address (as e.g. nlmeans definitely does)

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".