Re: [FFmpeg-devel] [PATCH 3/7] avfilter/vf_gblur_vulkan: omit unnecessary buffer usage flag

[Niklas Haas <ffmpeg@haasn.xyz>]

On Thu, 22 May 2025 06:32:42 +0900 Lynne <dev@lynne.ee> wrote:
> On 18/05/2025 21:11, Niklas Haas wrote:
> > From: Niklas Haas <git@haasn.dev>
> >
> > Implied internally now when needed.
> > ---
> >   libavfilter/vf_gblur_vulkan.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/libavfilter/vf_gblur_vulkan.c b/libavfilter/vf_gblur_vulkan.c
> > index 80b66de735..fb676a7fc9 100644
> > --- a/libavfilter/vf_gblur_vulkan.c
> > +++ b/libavfilter/vf_gblur_vulkan.c
> > @@ -171,7 +171,6 @@ static int init_gblur_pipeline(GBlurVulkanContext *s,
> >       RET(ff_vk_shader_register_exec(&s->vkctx, &s->e, shd));
> >
> >       RET(ff_vk_create_buf(&s->vkctx, params_buf, sizeof(float) * ksize, NULL, NULL,
> > -                         VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT |
> >                            VK_BUFFER_USAGE_STORAGE_BUFFER_BIT,
> >                            VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT));
> >       RET(ff_vk_map_buffer(&s->vkctx, params_buf, &kernel_mapped, 0));
>
> Its used in a lot more places than here, but its a start.

For the other use cases, I was not sure whether the code itself was taking
the buffer's address (as e.g. nlmeans definitely does)

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".