Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/7] avutil/vulkan: automatically enable shader device address usage bit
Date: Fri, 23 May 2025 14:14:15 +0200
Message-ID: <20250523141415.GC21491@haasn.xyz> (raw)
In-Reply-To: <fded9425-5381-4138-b8d7-cd98f333999b@lynne.ee>

On Thu, 22 May 2025 06:32:18 +0900 Lynne <dev@lynne.ee> wrote:
> On 18/05/2025 21:11, Niklas Haas wrote:
> > From: Niklas Haas <git@haasn.dev>
> >
> > We require this internally when using descriptor buffers, so it makes sense
> > to enable it internally, also.
> > ---
> >   libavutil/vulkan.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c
> > index 5f2ac6267d..97c008c809 100644
> > --- a/libavutil/vulkan.c
> > +++ b/libavutil/vulkan.c
> > @@ -989,6 +989,9 @@ int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size,
> >       int use_ded_mem;
> >       FFVulkanFunctions *vk = &s->vkfn;
> >
> > +    if (s->extensions & FF_VK_EXT_DESCRIPTOR_BUFFER)
> > +        usage |= VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT;
>
> You should omit the flag if the usage contains
> VK_BUFFER_USAGE_VIDEO_DECODE_SRC_BIT_KHR or
> VK_BUFFER_USAGE_VIDEO_ENCODE_DST_BIT_KHR, since its not used there.

I think a more robust logic would be to emit the flag only if the usage
contains any type that implies a descriptor (e.g. storage buffer, uniform
buffer, etc).

>
> > +
> >       VkBufferCreateInfo buf_spawn = {
> >           .sType       = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO,
> >           .pNext       = pNext,
>
> Apart from that, okay.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-05-23 12:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-18 12:11 [FFmpeg-devel] [PATCH 1/7] avutil/vulkan: add YUVA pixel formats support Niklas Haas
2025-05-18 12:11 ` [FFmpeg-devel] [PATCH 2/7] avutil/vulkan: automatically enable shader device address usage bit Niklas Haas
2025-05-21 21:32   ` Lynne
2025-05-23 12:14     ` Niklas Haas [this message]
2025-05-18 12:11 ` [FFmpeg-devel] [PATCH 3/7] avfilter/vf_gblur_vulkan: omit unnecessary buffer usage flag Niklas Haas
2025-05-21 21:32   ` Lynne
2025-05-23 12:14     ` Niklas Haas
2025-05-18 12:11 ` [FFmpeg-devel] [PATCH 4/7] avfilter/vf_blackdetect: add alpha option Niklas Haas
2025-05-18 12:11 ` [FFmpeg-devel] [PATCH 5/7] avfilter/blackdetect_vulkan: add hw accelerated blackdetect filter Niklas Haas
2025-05-21 21:36   ` Lynne
2025-05-18 12:11 ` [FFmpeg-devel] [PATCH 6/7] avfilter/alphadetect_vulkan: add alpha type detection filter Niklas Haas
2025-05-23 12:15   ` Niklas Haas
2025-05-18 12:11 ` [FFmpeg-devel] [PATCH 7/7] avutil/vf_scdet_vulkan: add new filter Niklas Haas
2025-05-21 21:37   ` Lynne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250523141415.GC21491@haasn.xyz \
    --to=ffmpeg@haasn.xyz \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git