[FFmpeg-devel] [PATCH v2] lavc/h2645_parse: More descriptive NALU header error

[FFmpeg-devel] [PATCH v2] lavc/h2645_parse: More descriptive NALU header error

[Frank Plowman]

Signed-off-by: Frank Plowman <post@frankplowman.com>
---
Changes since v1: Spotted just after sending this that there was ongoing
effort to remove av_strerror calls in favour of av_err2str, so made that
substitution here.
---
 libavcodec/h2645_parse.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c
index 82816999e8..fa57911c08 100644
--- a/libavcodec/h2645_parse.c
+++ b/libavcodec/h2645_parse.c
@@ -22,6 +22,7 @@
 
 #include "config.h"
 
+#include "libavutil/error.h"
 #include "libavutil/intmath.h"
 #include "libavutil/intreadwrite.h"
 #include "libavutil/mem.h"
@@ -588,8 +589,9 @@ int ff_h2645_packet_split(H2645Packet *pkt, const uint8_t *buf, int length,
         } else
             ret = h264_parse_nal_header(nal, logctx);
         if (ret < 0) {
-            av_log(logctx, AV_LOG_WARNING, "Invalid NAL unit %d, skipping.\n",
-                   nal->type);
+            av_log(logctx, AV_LOG_WARNING,
+                   "Failed to parse header of NALU (type %d): \"%s\". Skipping NALU.\n",
+                   nal->type, av_err2str(ret));
             continue;
         }
 
-- 
2.47.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] lavc/h2645_parse: More descriptive NALU header error

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 757 bytes --]

On Thu, May 22, 2025 at 07:43:02PM +0100, Frank Plowman wrote:
> Signed-off-by: Frank Plowman <post@frankplowman.com>
> ---
> Changes since v1: Spotted just after sending this that there was ongoing
> effort to remove av_strerror calls in favour of av_err2str, so made that
> substitution here.
> ---
>  libavcodec/h2645_parse.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

I think this is a good idea

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If one takes all money from those who grow wealth and gives it to those who
do not grow wealth, 10 years later, almost the same people who where wealthy
will be wealthy again, the same people who where poor will be poor again.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] lavc/h2645_parse: More descriptive NALU header error

[Nuo Mi]

On Sun, May 25, 2025 at 2:13 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Thu, May 22, 2025 at 07:43:02PM +0100, Frank Plowman wrote:
> > Signed-off-by: Frank Plowman <post@frankplowman.com>
> > ---
> > Changes since v1: Spotted just after sending this that there was ongoing
> > effort to remove av_strerror calls in favour of av_err2str, so made that
> > substitution here.
> > ---
> >  libavcodec/h2645_parse.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
>
> I think this is a good idea
>
Thank you, Frank and Michael.
Applied.

>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> If one takes all money from those who grow wealth and gives it to those who
> do not grow wealth, 10 years later, almost the same people who where
> wealthy
> will be wealthy again, the same people who where poor will be poor again.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".