Re: [FFmpeg-devel] Graphprint Patches Overview

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] Graphprint Patches Overview
Date: Thu, 22 May 2025 13:23:50 +0200
Message-ID: <20250522112350.GP29660@pb2> (raw)
In-Reply-To: <CABGuwEmyXEwwaffsjmfyrEP23iPgEiK3kmkYONjX1q_rXgumRQ@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2173 bytes --]

Hi Kieran

On Thu, May 22, 2025 at 08:21:48AM +0100, Kieran Kunhya via ffmpeg-devel wrote:
> It's obvious basic testing was not done on this patchset seeing the scale
> of memory leaks.
> 
> I would like the TC to decide on reverting and proper resubmission later.

Iam not speaking for the TC here

1. The graphprint code was on the ML for a month and resumbitted for review
    12 times, basically noone reviewed it (going back to that will not help it)
2. The graphprint code is very actively worked on (thats normal and good
    and what git master is for and thats how it improves quickly)
3. The statement that the graphprint code wasnt tested is obviously false
    softworkz tested it. I tested at least build on multiply platforms
4. "seeing the scale of memory leaks." try to compare this to
   IAMF "git log --grep IAMF --oneline", IAMF is after a year still receiving
   frequent security fixes. This is just as a comparission

What you are doing is trying to gain from somewhat popular oppinions
at the expense of the project and team.

many disliked the "opening of a browser" and thats now resolved
and reverted, but instead of letting the wounds heal you throw salt in them.
And while people are working and improving the code you push another
round of animosity

I dont really care if the code is all reverted or not. (it seems though
wiser to let people work on it as they already do)
What i do not agree with is this seeding of animosity you do.

This very much reminds me of
Simple Sabotage Field Manual
https://www.cia.gov/static/5c875f3ec660e092cf893f60b4a288df/SimpleSabotage.pdf

Also there is IMO nothing for the TC at this point. Its actively worked on code,
there is NO disagreement that any bugs or leaks need to be fixed.
And reverting this is not going to accelerate any fixes (if any bugs even remain).
Nor is it affecting anyone not using this new feature.
Your mails look like they are just for some sozial media buzz.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".