From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 113284B016 for ; Wed, 21 May 2025 07:53:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id E49FC68CA72; Wed, 21 May 2025 10:53:13 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id A242368CA72 for ; Wed, 21 May 2025 10:53:06 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id AAE5043A65 for ; Wed, 21 May 2025 07:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1747813985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pSFr8onAjEtruadmrJJKLtpMdmblDm1ZOfA6nlSfxWQ=; b=ZIIyH7I6RauAN1YmmKWt5tJHRc6kxEVvk+gVISJsM4yop+2PbPhWHudU+J82KWTDZgDESR dsqMYUwjiMhdbo/1xAGhOdEnIQR5gd9HXOSRiFekxvyGgku5yFzU8zbioMPZLUMR7kGE7Z N7/Gp8xuE6Z0dnzCrH+KpG1fxrg+T/M2jIws7fed3w2snLWGgKttnPOI26pJr04YhiHSI6 Fo3isLDuRCn1woGgfE88MPxC/VC/+vpY+USAZatirS39j1YJGEaNc0Mg9SKWWq90nfJEds v9MBLN4qT8B5KX7YtDTwHr/D8lIhO4bmV/RP7PC0/1PmVHfjjyHmTza4bRz8/g== Date: Wed, 21 May 2025 09:53:04 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250521075304.GN29660@pb2> References: <20250519144639.36733-1-romain.beauxis@gmail.com> <20250519144639.36733-4-romain.beauxis@gmail.com> <20250520214549.GJ29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddvheefucdltddurdegfedvrddttddmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpedutedvhfduuedugedufefghefhvedvgffgffekhfdvgfdvtefftdejkeehteefheenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v6 3/4] ogg/vorbis: implement header packet skip in chained ogg bitstreams. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6104748491408740379==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6104748491408740379== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fpmp1vfX9xdEhQ6Q" Content-Disposition: inline --fpmp1vfX9xdEhQ6Q Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Romain On Tue, May 20, 2025 at 05:45:01PM -0500, Romain Beauxis wrote: > Le mar. 20 mai 2025 =E0 16:46, Michael Niedermayer > a =E9crit : > > > > On Mon, May 19, 2025 at 09:46:38AM -0500, Romain Beauxis wrote: > > > --- > > > libavcodec/vorbis_parser.h | 11 ++++ > > > libavcodec/vorbisdec.c | 76 +++++++++++++-------= -- > > > libavformat/oggparsevorbis.c | 63 +++++++++++++++++- > > > tests/ref/fate/ogg-vorbis-chained-meta.txt | 3 - > > > 4 files changed, 116 insertions(+), 37 deletions(-) > > > > breaks fate here (normal x86-64 ubuntu) > > > > --- ./tests/ref/fate/ogg-vorbis-chained-meta.txt 2025-05-20 23:4= 2:32.043927021 +0200 > > +++ tests/data/fate/ogg-vorbis-chained-meta 2025-05-20 23:43:07.908= 216645 +0200 > > @@ -7,8 +7,4 @@ > > Stream ID: 0, frame PTS: 704, metadata: N/A > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, new metadata: encoder=3DLavc61.19.100 libvorbis:title=3D= Second Stream > > -Stream ID: 0, frame PTS: 0, metadata: N/A > > Stream ID: 0, packet PTS: 128, packet DTS: 128 > > -Stream ID: 0, frame PTS: 128, metadata: N/A > > -Stream ID: 0, packet PTS: 704, packet DTS: 704 > > -Stream ID: 0, frame PTS: 704, metadata: N/A > > Test ogg-vorbis-chained-meta failed. Look at tests/data/fate/ogg-vorbis= -chained-meta.err for details. > > make: *** [tests/Makefile:316: fate-ogg-vorbis-chained-meta] Error 1 >=20 > I'm not sure what I'm looking at. Is that the output of running the FATE = tests? yes probably was make fate-ogg-vorbis-chained-meta >=20 > This diff is already included in the patch: >=20 > ``` > % git show 37370e99451cf0750d5304764ba9031b80e5b3e0 tests/ > commit 37370e99451cf0750d5304764ba9031b80e5b3e0 (HEAD) > Author: Romain Beauxis > Date: Sat May 17 12:59:40 2025 -0500 >=20 > ogg/vorbis: implement header packet skip in chained ogg bitstreams. >=20 > diff --git a/tests/ref/fate/ogg-vorbis-chained-meta.txt > b/tests/ref/fate/ogg-vorbis-chained-meta.txt > index b7a97c90e2..1206f86c1f 100644 > --- a/tests/ref/fate/ogg-vorbis-chained-meta.txt > +++ b/tests/ref/fate/ogg-vorbis-chained-meta.txt > @@ -6,10 +6,7 @@ Stream ID: 0, frame PTS: 128, metadata: N/A > Stream ID: 0, packet PTS: 704, packet DTS: 704 > Stream ID: 0, frame PTS: 704, metadata: N/A > Stream ID: 0, packet PTS: 0, packet DTS: 0 > -Stream ID: 0, packet PTS: 0, packet DTS: 0 > Stream ID: 0, new metadata: encoder=3DLavc61.19.100 libvorbis:title=3DSe= cond Stream > -Stream ID: 0, packet PTS: 0, packet DTS: 0 > -Stream ID: 0, packet PTS: 0, packet DTS: 0 > Stream ID: 0, frame PTS: 0, metadata: N/A > Stream ID: 0, packet PTS: 128, packet DTS: 128 > Stream ID: 0, frame PTS: 128, metadata: N/A These 2 diffs are not the same thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth. --fpmp1vfX9xdEhQ6Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaC2GYAAKCRBhHseHBAsP qwM7AJ9YMy7ur3WyIXq7ty/ebogJguZNVgCfY3XzVg3qg7jDL8A1mTMF/V3b4hc= =FL2F -----END PGP SIGNATURE----- --fpmp1vfX9xdEhQ6Q-- --===============6104748491408740379== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6104748491408740379==--