From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 0ABE94AF82 for ; Wed, 21 May 2025 07:41:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id AA85468CC06; Wed, 21 May 2025 10:41:06 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5C90B68CBA8 for ; Wed, 21 May 2025 10:40:59 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8AB40439D8 for ; Wed, 21 May 2025 07:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1747813258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SE1Iw7Y643cecnEacODBZ2a/DONmCKdRTnwFSl6z4VQ=; b=UIdXw5L73jDITjWuqcGrybgEuRrTul80jiZJiZcckOYw/Ap5GuwPkUu6V3UrVvEueJs26n uFnayEP5aHZ3Zqsbn3lhT21fX8W14S3TjmC4/3DGnibf0vHzyi/zlO48DrKnstS1P30+xS Ike56ZWkEAv+0TtDjtSXwIaIm9cWF2jIWXRI7OhhOvZsBasawsGT9Gz8vD9wVtWcPvPBFX Zq2S31t/gVDBCtrTZQGRoEBnQ8YA+xkGVFD45SPwdtk3pbVZYgZQbpyml+WHYGEkwSMyIa t1qZVBxE7Y3Cv/fm4NdF/Q5DoOZJQPvTSbSyNnPQ5dSA0sSqJzg/QCmM0+jcew== Date: Wed, 21 May 2025 09:40:57 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250521074057.GL29660@pb2> References: <20250519121537.509658-1-chenyu202107@gmail.com> <20250519121537.509658-2-chenyu202107@gmail.com> <20250521004642.GK29660@pb2> MIME-Version: 1.0 In-Reply-To: <20250521004642.GK29660@pb2> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddvhedtucdltddurdegfedvrddttddmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/1] [ffmpeg-deve] avcodec/mpegaudiodec optimizing code size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4671476246301406058==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4671476246301406058== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tI9tJD/InAKWF1Ci" Content-Disposition: inline --tI9tJD/InAKWF1Ci Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 21, 2025 at 02:46:42AM +0200, Michael Niedermayer wrote: > On Mon, May 19, 2025 at 08:15:37PM +0800, chenyu202107@gmail.com wrote: > > From: chenyu > >=20 > > Optimizing 160k code size by converting static array to dynamic malloc = memory. > >=20 > > Signed-off-by: chenyu > > --- > > libavcodec/mpegaudiodata.h | 4 ++-- > > libavcodec/mpegaudiodec_common_tablegen.h | 10 ++++++++-- > > 2 files changed, 10 insertions(+), 4 deletions(-) >=20 > This segfaults: >=20 > ./ffmpeg_g -max_error_rate 2 -max_alloc 100000 -i ~/tickets/2950/mpeg2_fu= zz.mpg -max_muxing_queue_size 8000 -f null - =3D=3D3638361=3D=3D Invalid write of size 4 =3D=3D3638361=3D=3D at 0x2DFB01: mpegaudiodec_common_init_static (in ffm= peg/ffmpeg_g) =3D=3D3638361=3D=3D by 0x4A114DE: __pthread_once_slow (pthread_once.c:11= 6) =3D=3D3638361=3D=3D by 0x2DFBB1: ff_mpegaudiodec_common_init_static (in = ffmpeg/ffmpeg_g) =3D=3D3638361=3D=3D by 0x4A114DE: __pthread_once_slow (pthread_once.c:11= 6) =3D=3D3638361=3D=3D by 0x2A6FFD: decode_init (in ffmpeg/ffmpeg_g) =3D=3D3638361=3D=3D by 0x7E4BF1: avcodec_open2 (in ffmpeg/ffmpeg_g) =3D=3D3638361=3D=3D by 0x62C444: try_decode_frame (in ffmpeg/ffmpeg_g) =3D=3D3638361=3D=3D by 0x631575: avformat_find_stream_info (in ffmpeg/ff= mpeg_g) =3D=3D3638361=3D=3D by 0x306596: ifile_open (in ffmpeg/ffmpeg_g) =3D=3D3638361=3D=3D by 0x31CA17: open_files.isra.0 (in ffmpeg/ffmpeg_g) =3D=3D3638361=3D=3D by 0x31E9F5: ffmpeg_parse_options (in ffmpeg/ffmpeg_= g) =3D=3D3638361=3D=3D by 0x2FD297: main (in ffmpeg/ffmpeg_g) =3D=3D3638361=3D=3D Address 0x4 is not stack'd, malloc'd or (recently) fre= e'd [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB For a strong democracy, genuine criticism is necessary, allegations benefit noone, they just cause unnecessary conflicts. - Narendra Modi --tI9tJD/InAKWF1Ci Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaC2DhQAKCRBhHseHBAsP q7mfAJ4hgtPMZlzEBaXu4dSOKXoxBC65ygCdHnGvd5AyNTsCGx9P+Jicopfx+7s= =qhDw -----END PGP SIGNATURE----- --tI9tJD/InAKWF1Ci-- --===============4671476246301406058== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4671476246301406058==--