[FFmpeg-devel] [PATCH 0/3] Clean up build spam from graph css builder

[FFmpeg-devel] [PATCH 0/3] Clean up build spam from graph css builder

[Derek Buitenhuis]

I am not sure how this made it in.

Before:
    $ rm fftools/resources/graph.css.c
    $ make
    # Must start with a tab in the real Makefile
    sed 's!/\\*.*\\*/!!g' fftools/resources/graph.css \
    | tr '\n' ' ' \
    | tr -s ' ' \
    | sed 's/^ //; s/ $//' \
    > fftools/resources/graph.css.min
    GEN     fftools/resources/graph.css.min.gz
    BIN2C   fftools/resources/graph.css.c
    CC      fftools/resources/graph.css.o
    LD      ffmpeg_g
    STRIP   ffmpeg
    LD      ffprobe_g
    STRIP   ffprobe
    rm fftools/resources/graph.css.min.gz fftools/resources/graph.css.min
    $

After:
    $ rm fftools/resources/graph.css.c
    $ make
    GEN     fftools/resources/graph.css.min
    GEN     fftools/resources/graph.css.min.gz
    BIN2C   fftools/resources/graph.css.c
    CC      fftools/resources/graph.css.o
    LD      ffmpeg_g
    STRIP   ffmpeg
    LD      ffprobe_g
    STRIP   ffprobe
    $

Derek Buitenhuis (3):
  ffbuild/common: Remove what appears to be a temporary debugging
    comment
  ffbuild/common: Properly tag/suppress sed command
  fftools/resoirces: Mark .css.min and .css.min.gz as NOTINTERMEDIATE

 ffbuild/common.mak         | 3 +--
 fftools/resources/Makefile | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/3] ffbuild/common: Remove what appears to be a temporary debugging comment

[Derek Buitenhuis]

This also prevents it from always spamming during build.

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 ffbuild/common.mak | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ffbuild/common.mak b/ffbuild/common.mak
index 0e1eb1f62b..b90d9519cb 100644
--- a/ffbuild/common.mak
+++ b/ffbuild/common.mak
@@ -141,7 +141,6 @@ endif
 
 # 1) Preprocess CSS to a minified version
 %.css.min: %.css
-	# Must start with a tab in the real Makefile
 	sed 's!/\\*.*\\*/!!g' $< \
 	| tr '\n' ' ' \
 	| tr -s ' ' \
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/3] ffbuild/common: Properly tag/suppress sed command

[Derek Buitenhuis]

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 ffbuild/common.mak | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ffbuild/common.mak b/ffbuild/common.mak
index b90d9519cb..a3b7974f63 100644
--- a/ffbuild/common.mak
+++ b/ffbuild/common.mak
@@ -141,7 +141,7 @@ endif
 
 # 1) Preprocess CSS to a minified version
 %.css.min: %.css
-	sed 's!/\\*.*\\*/!!g' $< \
+	$(M)sed 's!/\\*.*\\*/!!g' $< \
 	| tr '\n' ' ' \
 	| tr -s ' ' \
 	| sed 's/^ //; s/ $$//' \
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 3/3] fftools/resoirces: Mark .css.min and .css.min.gz as NOTINTERMEDIATE

[Derek Buitenhuis]

Prevents un-formatted build spam and deletion.

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 fftools/resources/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fftools/resources/Makefile b/fftools/resources/Makefile
index 8579a52678..a598134c24 100644
--- a/fftools/resources/Makefile
+++ b/fftools/resources/Makefile
@@ -6,6 +6,7 @@ vpath %.css  $(SRC_PATH)
 
 # Uncomment to prevent deletion during build
 #.PRECIOUS: %.css.c %.css.min %.css.gz %.css.min.gz %.html.gz %.html.c
+.NOTINTERMEDIATE: %.css.min %.css.min.gz
 
 OBJS-resman +=                     \
     fftools/resources/resman.o     \
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 0/3] Clean up build spam from graph css builder

[softworkz .]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Derek
> Buitenhuis
> Sent: Dienstag, 20. Mai 2025 20:28
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 0/3] Clean up build spam from graph css builder
> 
> I am not sure how this made it in.
> 
> Before:
>     $ rm fftools/resources/graph.css.c
>     $ make
>     # Must start with a tab in the real Makefile
>     sed 's!/\\*.*\\*/!!g' fftools/resources/graph.css \
>     | tr '\n' ' ' \
>     | tr -s ' ' \
>     | sed 's/^ //; s/ $//' \
>     > fftools/resources/graph.css.min
>     GEN     fftools/resources/graph.css.min.gz
>     BIN2C   fftools/resources/graph.css.c
>     CC      fftools/resources/graph.css.o
>     LD      ffmpeg_g
>     STRIP   ffmpeg
>     LD      ffprobe_g
>     STRIP   ffprobe
>     rm fftools/resources/graph.css.min.gz fftools/resources/graph.css.min
>     $
> 
> After:
>     $ rm fftools/resources/graph.css.c
>     $ make
>     GEN     fftools/resources/graph.css.min
>     GEN     fftools/resources/graph.css.min.gz
>     BIN2C   fftools/resources/graph.css.c
>     CC      fftools/resources/graph.css.o
>     LD      ffmpeg_g
>     STRIP   ffmpeg
>     LD      ffprobe_g
>     STRIP   ffprobe
>     $
> 
> Derek Buitenhuis (3):
>   ffbuild/common: Remove what appears to be a temporary debugging
>     comment
>   ffbuild/common: Properly tag/suppress sed command
>   fftools/resoirces: Mark .css.min and .css.min.gz as NOTINTERMEDIATE
> 
>  ffbuild/common.mak         | 3 +--
>  fftools/resources/Makefile | 1 +
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --

Hi Derek,

thanks a lot for the patch. This partially duplicates what Timo had
already submitted:

https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250516230202.355445-1-timo@rothenpieler.org/

Regarding patch 3/3, would you mind taking a look at the patch that I 
have submitted in this regard, from which I believe that it's the "most
correct" way:

https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.80.v2.ffstaging.FFmpeg.1747549830700.ffmpegagent@gmail.com/

Thanks again,
sw



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 0/3] Clean up build spam from graph css builder

[Derek Buitenhuis]

On 5/20/2025 7:44 PM, softworkz . wrote:
> Hi Derek,
> 
> thanks a lot for the patch. This partially duplicates what Timo had
> already submitted:
> 
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250516230202.355445-1-timo@rothenpieler.org/

Dropping this set, then.

> Regarding patch 3/3, would you mind taking a look at the patch that I 
> have submitted in this regard, from which I believe that it's the "most
> correct" way:
> 
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.80.v2.ffstaging.FFmpeg.1747549830700.ffmpegagent@gmail.com/

I am actually unclear on which is "most correct", myself.

[...]

- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 0/3] Clean up build spam from graph css builder

[softworkz .]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Derek
> Buitenhuis
> Sent: Mittwoch, 21. Mai 2025 15:27
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 0/3] Clean up build spam from graph css
> builder
> 
> On 5/20/2025 7:44 PM, softworkz . wrote:
> > Hi Derek,
> >
> > thanks a lot for the patch. This partially duplicates what Timo had
> > already submitted:
> >
> > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250516230202.355445-1-
> timo@rothenpieler.org/
> 
> Dropping this set, then.
> 
> > Regarding patch 3/3, would you mind taking a look at the patch that I
> > have submitted in this regard, from which I believe that it's the "most
> > correct" way:
> >
> >
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.80.v2.ffstaging.FFmpeg.
> 1747549830700.ffmpegagent@gmail.com/
> 
> I am actually unclear on which is "most correct", myself.
> 
> [...]
> 
> - Derek
> _______________________________________________

I can't say that I have great expertise with Makefile development. I read the 
documentation and then I created a super-simple test to verify my understanding.
The Makefile content is this:

# Makefile
%.t: %.r.tmp
	./cmd1 $< $@

%.r.tmp: %.q
	./cmd2 $< $@

%.q: %.r
	./cmd3 $< $@


and every cmd1, cmd2 and cmd3 does nothing else but copy the file. The "source"
file is test.t and no other files exist at the beginning.

When running make, it copies test.t to test.tmp and then test.tmp to test.r and
finally it deletes test.tmp.

When you run make again, it says everything is up to date. When you touch test.t,
it re-builds the result.

That's why I said I believe it's the "most correct" way and that's the behavior
that my patch is introducing. At the same time it allows to get rid of a few
lines (the filtering of files and adding them to the SECONDARY special target).

Thanks
sw











_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".