Re: [FFmpeg-devel] [PATCH v5 1/7] libavformat/oggdec.h: Document packet function return value.

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1547 bytes --]

On Fri, May 16, 2025 at 12:39:36PM -0500, Romain Beauxis wrote:
> Le mer. 14 mai 2025 à 17:32, Michael Niedermayer <michael@niedermayer.cc> a
> écrit :
> >
> > On Fri, May 09, 2025 at 06:43:21PM -0500, Romain Beauxis wrote:
> > > ---
> > >  libavformat/oggdec.h | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/libavformat/oggdec.h b/libavformat/oggdec.h
> > > index 43df23f4cb..5225b77a07 100644
> > > --- a/libavformat/oggdec.h
> > > +++ b/libavformat/oggdec.h
> > > @@ -38,6 +38,12 @@ struct ogg_codec {
> > >       *         -1 if an error occurred or for unsupported stream
> > >       */
> > >      int (*header)(AVFormatContext *, int);
> > > +    /**
> > > +     * Attempt to process a packet as a data packet
> > > +     * @return < 0 (AVERROR) code or -1 on error
> > > +     *         == 0 if the packet was a regular data packet.
> > > +     *         == 0 or 1 if the packet was a header from a chained
> bitstream.
> > > +     */
> > >      int (*packet)(AVFormatContext *, int);
> > >      /**
> > >       * Translate a granule into a timestamp.
> > > --
> >
> > will apply, so the patchset becomes smaller
> 
> Thanks!
> 
> I'll address the comments on the vorbis diff.
> 
> Opus and flac could go in too if you want.

no objection, if someone wants to apply them

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".