From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 891D94D15C for ; Fri, 16 May 2025 08:11:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1340D68C7D0; Fri, 16 May 2025 11:11:11 +0300 (EEST) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8762468C74E for ; Fri, 16 May 2025 11:11:04 +0300 (EEST) Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-32803984059so8339371fa.2 for ; Fri, 16 May 2025 01:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1747383063; x=1747987863; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=R0s7zYlU6p1XUHYsy/CrkHT1ZI5cTeTzO8vE7I+CIXE=; b=knuLkzzBwuce9p2JBPMkKyEyDRtOom/ewPEM323uEH6Q+izM905IcjJVMjzzBEn4W3 9A1WLT3HfVFgis+2faXB8pJz2rlPtkakBEwnSjXfR0WKJTSetZkSpephloE+FATb6eir 3sSszG4gxVOtYDIBUNSBaMwW371c62VqAo5Guum00B4ZGBGAQd78YcENLZqp74arssah y0wXBBiawL2O445lj2GoTo620K9tMtcq1xTRuUK+hGg9lc1Sz+zlueBU+F/PFVusBcJF cgpoFKLo4qyIwOryR2bawOdC9ZP6ixLWgAPsmoClw79Jn586SIPXuT/D/Rjl02ntjtt7 ptNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747383063; x=1747987863; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R0s7zYlU6p1XUHYsy/CrkHT1ZI5cTeTzO8vE7I+CIXE=; b=rWQEdsGIMESQ+bmRRZifNrmKHQtd6Pd71Ipx2O9ZnOGfsaek0QBrHAwilH2JqIGLwu STaczCgKvos1zlXOfVRsAiXjo9tTPG3r3Po7mJebFXBvHkpJM4VJ/sVcVHGV/FiDDBBK d+z+4rM76Tqs1rneW+SSgMIya6FpADO4blGni7LiI/w8giyOwVnsgYsNI7iDZvOD7ZfB 3GP+7DYJP5QlwheuqpI4HzcpEhupFQRH/iwlgf8aCknitpHPP91rPPJrYMPYwKASUKm6 +AP1Tf45nrVv/cJXJN+LY/V0wtjEmsLMrPmDkgOq84R1+Rz4gmDnkampfP7zcj3Xe48c uLcA== X-Gm-Message-State: AOJu0YwBvq+ftiJKVb3sQTaL06KTwzH+y0mviO3A9HbxKMzXfdZdKbqi x6AlzIzoTmKoDe2SbWKPiRTD7jLc2BI96OVfCdG7vZe4qEp82NMfD3KvDOi+vzVaKY0KfhquN3g AH9mfXQ== X-Gm-Gg: ASbGncu3H2k5z+aoaqfnyMw7NystUfwhU+6zXl4VoSzpEyKUXLh0xSXxKlkS0CGZm2N Xxpt5gIesqlyNDp563CzgE+xYxe1DlYHErn4jzluA+sDpDbBT0AIc5TWQl0yzxZ+0tXJ7KfFswj KXq+7d/nb0ac7VNWhBs0PZ+bCzFoMdAuHMzUP2oUHr1QqSrx589ATBrI5+func3NaJYTwxe+ylW M/d/r9qC18MwQtUpuNswesrOGOPHvywhAe8i+BiEYSL9F9jRrYEuSZSNpjdGnERJ2XjK0tSKAH9 JdAjOrWY0qJ4yFWvLhTLGmPrQPKv7fK4mtmGxoKC4IZKX4R6iQz/OhEgJZslUO24TOSMMYj1Zii i6lH0CcVVgz0neIvNRw== X-Google-Smtp-Source: AGHT+IHHvtcgqixW65/ge8Upo+rITKxD42ZUP5c0Eu4nf44elaUVtcdHL9+h7gpr4DnRjW1lBy7Aeg== X-Received: by 2002:a05:651c:3041:b0:326:d4e5:5beb with SMTP id 38308e7fff4ca-328076fbedemr7229971fa.9.1747383063437; Fri, 16 May 2025 01:11:03 -0700 (PDT) Received: from localhost (dsl-tkubng21-50de30-198.dhcp.inet.fi. [80.222.48.198]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-328084b6c7csm3026091fa.2.2025.05.16.01.11.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 May 2025 01:11:03 -0700 (PDT) From: =?UTF-8?q?Martin=20Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Fri, 16 May 2025 11:10:58 +0300 Message-ID: <20250516081102.396446-1-martin@martin.st> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] [FATE] Properly list test errors when there are no failed tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: If there were failures while running tests, e.g. if failing to compile checkasm or any other of the test programs, there are no failed tests per se, and the number of succeessful tests is equal to the total number of tests. For these cases, check the job status code instead of declaring them as a full success. --- history.cgi | 2 +- index.cgi | 2 +- report.cgi | 6 +++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/history.cgi b/history.cgi index 533999c..d0a855d 100755 --- a/history.cgi +++ b/history.cgi @@ -76,7 +76,7 @@ for my $date ((sort { $b cmp $a } @reps)[0..49]) { td $$rep{nwarn}; if ($npass) { $rtext = "$npass / $ntest"; - $rclass = $npass==$ntest? 'pass' : $npass? 'warn' : 'fail'; + $rclass = $$rep{status}==0? 'pass' : $npass? 'warn' : 'fail'; } elsif (!$ntest and !$$rep{status}) { $rtext = "build only"; $rclass = $$rep{status}? 'fail' : 'pass'; diff --git a/index.cgi b/index.cgi index 25c61e9..89e599a 100755 --- a/index.cgi +++ b/index.cgi @@ -286,7 +286,7 @@ for my $rep (sort repcmp @reps) { td $$rep{comment}, class => 'comment'; if ($npass) { $rtext = "$npass / $ntest"; - $rclass = $npass==$ntest? 'pass' : $npass? 'warn' : 'fail'; + $rclass = $$rep{status}==0? 'pass' : $npass? 'warn' : 'fail'; } elsif (!$ntest and !$$rep{status}) { $rtext = "build only"; $rclass = $$rep{status}? 'fail' : 'pass'; diff --git a/report.cgi b/report.cgi index 5a2394d..ca003b1 100755 --- a/report.cgi +++ b/report.cgi @@ -183,7 +183,11 @@ if ($nfail) { } end 'tbody'; } elsif ($ntest) { - start 'tr', class => 'pass'; th 'All tests successful', colspan => 3; end; + if ($$hdr{status}) { + start 'tr', class => 'fail'; th 'Failure building tests', colspan => 3; end; + } else { + start 'tr', class => 'pass'; th 'All tests successful', colspan => 3; end; + } } else { my $class = $$hdr{status}? 'fail' : 'pass'; start 'tr', class => $class; th 'No tests were run', colspan => 3; end; -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".