From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5FB264CC5D for ; Tue, 13 May 2025 16:25:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B2A5E68B253; Tue, 13 May 2025 19:25:41 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A2582687C5A for ; Tue, 13 May 2025 19:25:35 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id AAA31438BB for ; Tue, 13 May 2025 16:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1747153534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZkaM7CeajaXPQqO8Y9MdRv/sNVmYxcRIkKLSDsgQ0q8=; b=j7wekIq0CsWOgMhqLKAGuxmUZfqAFo3nnOQUxC+V6/U0+a1q9adFXW1D+l+fsjeDs+mBRB Bq3JMdn2litw8MGcxtKs4YCZz7pV5Y4Vn2wKrP+y74VjU+7tymn2rEzo6keoxGKUn9q8dj 3b0qClHlrXFDGKYiS1qiWW/5Vl+EOpAIuF/dqvBpw68JAAO47OFwdHZkyH1qGYc7q9JFWr 422ISLNM9ydBPYUBEbTARGX7YkKgE2qH8osYJxui7NBRfkydhE1EkVs0oCyq10GuRSlEhV cmLvtSUsNSg2hfAFliDBAcNaGa24D2YY12PKe22+bVg0BXFaqhjfp6mYOLunsA== Date: Tue, 13 May 2025 18:25:33 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250513162533.GE29660@pb2> References: <20250510155109.1358-1-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250510155109.1358-1-jamrial@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeftdegheekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeetgfegvdffieeuffevhfeitdfgfeejudekfeegteegveegjeegkedvveejleevkeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/iamf_parse: increase PutBytes buffer when writing AAC extradata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2007113553113430605==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2007113553113430605== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yUw0eFUXHKnFujKq" Content-Disposition: inline --yUw0eFUXHKnFujKq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 10, 2025 at 12:51:09PM -0300, James Almer wrote: > We may write up to 43 bits, so 5 bytes is not enough. >=20 > Fixes: Assertion n>=3D0 && n<=3D32 failed at ./libavcodec/get_bits.h:406 > Fixes: 398527871/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-66= 02025714647040 >=20 > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/t= ree/master/projects/ffmpeg > Signed-off-by: James Almer > --- > libavformat/iamf_parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c > index abedfdb066..14b69855c9 100644 > --- a/libavformat/iamf_parse.c > +++ b/libavformat/iamf_parse.c > @@ -285,7 +285,7 @@ static int update_extradata(AVCodecParameters *codecp= ar) > AV_WL16A(codecpar->extradata + 16, AV_RB16A(codecpar->extradata = + 16)); // Byte swap Output Gain > break; > case AV_CODEC_ID_AAC: { > - uint8_t buf[5]; > + uint8_t buf[6]; fails fate (with assertions enabled) libavutil 60. 2.100 / 60. 2.100 libavcodec 62. 3.101 / 62. 3.101 libavformat 62. 0.102 / 62. 0.102 libavdevice 62. 0.100 / 62. 0.100 libavfilter 11. 0.100 / 11. 0.100 libswscale 9. 0.100 / 9. 0.100 libswresample 6. 0.100 / 6. 0.100 Assertion n>=3D0 && n<=3D32 failed at ./libavcodec/get_bits.h:406 Aborted (core dumped) threads=3D1 make: *** [tests/Makefile:316: fate-iamf-stereo-demux] Error 134 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who speaks, does not know. -- Lao Tsu --yUw0eFUXHKnFujKq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaCNydAAKCRBhHseHBAsP qwR6AKCBG+LHD/ej74p4e423m6fjXgsE7ACfXsRJYWat7oN7sDa5HAOj0w5or/c= =enAj -----END PGP SIGNATURE----- --yUw0eFUXHKnFujKq-- --===============2007113553113430605== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2007113553113430605==--