From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 48AB74EA3E for ; Mon, 12 May 2025 09:04:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7853068C05F; Mon, 12 May 2025 12:03:58 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 77C0A68BDC8 for ; Mon, 12 May 2025 12:03:51 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9EFDF41C93 for ; Mon, 12 May 2025 09:03:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1747040630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V4PFhVcFxeC5b3Lgm0tdTO9fYnVZEP1uOOWe1IbIUKs=; b=Tsdff3NIVQCgSTmwQ53tExviOnLukw2X5rBYnlCXbKTHiYK8IjNmUJQhxujw4tKDefJI8A EJmK2b8FvDKmTNQ3WpIK8pg0BetqaPpZDdEzwmS0RJi5o1YZBHYVCyMml1h216hZF2lYF+ rwDz5xqMqDSYttq0X4KbgFA9VhdnqHA/i92SOObVaWQxSOSrh/JXV5Vg8aW1VgLhSLXw7V pLQ0USXWPxi5S8zU3I021JzIGn09Kct92MlqZNYVOCp2nhlfZc/t/3G4TFHDMXsuKdOa42 eZoAPRCTyx63eg3auTqN3KDVRtZFwbxt4Mctqk8y/WLhMoWIc0XiiH7G8+9R2Q== Date: Mon, 12 May 2025 11:03:49 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250512090349.GZ29660@pb2> References: <20250511233635.2961367-1-xiongweixiaoxxw@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250511233635.2961367-1-xiongweixiaoxxw@gmail.com> X-GND-State: clean X-GND-Score: -90 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeftddtkeehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculddutddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeffledtfeevfeffheeuuefhtdejieelueeftdeitdfgheetgefffeefteekffdthfenucffohhmrghinhepfhhfmhhpvghgrdhorhhgnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v3] lavf: vvc_probe: enforce SPS -> PPS -> IRAP detection order to fix invalid stream detection X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8427725159936988206==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8427725159936988206== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DHd0DHvhbdljNSqO" Content-Disposition: inline --DHd0DHvhbdljNSqO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 12, 2025 at 07:36:35AM +0800, xiongweixiao wrote: > The current vvc_probe function checks for SPS, PPS, and IRAP NAL units bu= t does not enforce their detection order. This can lead to false positives = when PPS or IRAP appear before SPS, causing malformed or non-compliant bits= treams to be incorrectly identified as valid VVC streams. >=20 > This patch modifies the logic to use boolean flags and enforces the corre= ct detection sequence: SPS must be detected before PPS, and PPS before IRAP= =2E This ensures more accurate probing and prevents invalid bitstreams from= being misidentified. >=20 > This change addresses issues reported in: > - https://trac.ffmpeg.org/ticket/11496 > - https://trac.ffmpeg.org/ticket/11087 >=20 > Signed-off-by: xiongweixiao >=20 > [v2] lavf: vvc_probe: fix based on review feedback >=20 > Changes since v1: > - Added a flag to force sps, pps, iraq to appear in order; > - Modified score where pps, iraq appeared in the wrong position; > - Set a smaller score for incomplete sps, pps, iraq to deal with situatio= ns that may look like vvc format >=20 > Signed-off-by: xiongweixiao >=20 > [v3] lavf fix code format > remove trailing whitspace > --- > libavformat/vvcdec.c | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) will apply patch with updated commit message thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The smallest minority on earth is the individual. Those who deny=20 individual rights cannot claim to be defenders of minorities. - Ayn Rand --DHd0DHvhbdljNSqO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaCG5awAKCRBhHseHBAsP q9i/AJ42S5ryO8oLWjMSBKEP8qNYM1XxpgCgkOlwYSL/mNuXif6vsAqopPfrLFA= =OkgX -----END PGP SIGNATURE----- --DHd0DHvhbdljNSqO-- --===============8427725159936988206== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8427725159936988206==--