From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3EBC94C8E7 for ; Sun, 11 May 2025 10:45:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6283568C21E; Sun, 11 May 2025 13:45:26 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1533568AA8F for ; Sun, 11 May 2025 13:45:20 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5F00143284; Sun, 11 May 2025 10:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1746960319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IwQ0AYgRU/Nz8/sBgEgyik1y54kwVwMlFEpjnWJJo/Q=; b=RzxJRzhf4yN5UpMDtMIdsCF36PPDEtCA1lH1c1j0rV8FAloUxso9rZwnH2onacpH75VwTG Th78o9HavgjFjlMjO27EoXcrwY2B+UZy96W76XdMkMEwqxZPS8CqdLzDcphzSSHKIh/+BS x6OyRzlFrMKJHvaQjaRNxni3mWh8VkGSaN46PwIIYlQMFi2OCiSK81dmNU67C+I0XS76EG ho5W01IHWb2KtUlUSs/+3sqwtukdgvZ/sFodwvJj9gHxuRIWP4LIBlrQDggsRyfbSenl8w Y8rkPoi2dCRy6Q/sdcJoZYcUgkC6NYaIyl+d6cNBceeUKCaQQ/mA6uofXxUrcQ== Date: Sun, 11 May 2025 12:45:18 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250511104518.GV29660@pb2> References: <20250511050814.966335-1-xiongweixiaoxxw@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250511050814.966335-1-xiongweixiaoxxw@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvleekudejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieejuefgieffheekhfejheevfeekuefhtedvleeigfdtkeffhfeihffhhfevjeeknecuffhomhgrihhnpehffhhmphgvghdrohhrghenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepvddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhgpdhrtghpthhtohepgihiohhnghifvghigihirghogiigfiesghhmrghilhdrtghomh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] lavf: vvc_probe: enforce SPS -> PPS -> IRAP detection order to fix invalid stream detection X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: xiongweixiao Content-Type: multipart/mixed; boundary="===============1763647943182974448==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1763647943182974448== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KxKI/R+N9hudrWbn" Content-Disposition: inline --KxKI/R+N9hudrWbn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi xiongweixiao On Sun, May 11, 2025 at 01:08:14PM +0800, xiongweixiao wrote: > The current vvc_probe function checks for SPS, PPS, and IRAP NAL units bu= t does not enforce their detection order. This can lead to false positives = when PPS or IRAP appear before SPS, causing malformed or non-compliant bits= treams to be incorrectly identified as valid VVC streams. >=20 > This patch modifies the logic to use boolean flags and enforces the corre= ct detection sequence: SPS must be detected before PPS, and PPS before IRAP= =2E This ensures more accurate probing and prevents invalid bitstreams from= being misidentified. >=20 > This change addresses issues reported in: > - https://trac.ffmpeg.org/ticket/11496 > - https://trac.ffmpeg.org/ticket/11087 I suggest to return a lower score when pps / irap occur in the wrong location. And the current score if they ever occur in the correct location This way mp3 will be detected fine but also somewhat malformed VVC can still be detected thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of discord comes the fairest harmony. -- Heraclitus --KxKI/R+N9hudrWbn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaCB/tAAKCRBhHseHBAsP qwpVAKCKlLrPt7oVxNWO6zEtidkouf14OQCcDjqVDwRhBP4bcLyVVTW/ZUSvMHY= =hzVd -----END PGP SIGNATURE----- --KxKI/R+N9hudrWbn-- --===============1763647943182974448== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1763647943182974448==--