Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 7/8] avcodec/svq3: Check that for 8 byte space before subtracting
Date: Sun, 11 May 2025 02:32:44 +0200
Message-ID: <20250511003245.413345-7-michael@niedermayer.cc> (raw)
In-Reply-To: <20250511003245.413345-1-michael@niedermayer.cc>

No testcase

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/svq3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c
index f730358e2f9..30bc9334af7 100644
--- a/libavcodec/svq3.c
+++ b/libavcodec/svq3.c
@@ -1173,7 +1173,7 @@ static av_cold int svq3_decode_init(AVCodecContext *avctx)
         int w,h;
 
         size = AV_RB32(&extradata[4]);
-        if (size > extradata_end - extradata - 8)
+        if (extradata_end - extradata < 8 || size > extradata_end - extradata - 8)
             return AVERROR_INVALIDDATA;
         init_get_bits(&gb, extradata + 8, size * 8);
 
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2025-05-11  0:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-11  0:32 [FFmpeg-devel] [PATCH 1/8] avcodec/dnxuc_parser: Use ff_parse_close() Michael Niedermayer
2025-05-11  0:32 ` [FFmpeg-devel] [PATCH 2/8] avformat/mov: reject negative ELST durations Michael Niedermayer
2025-05-11  0:32 ` [FFmpeg-devel] [PATCH 3/8] avformat/imf_cpl: do not continue looping forever Michael Niedermayer
2025-05-11  0:32 ` [FFmpeg-devel] [PATCH 4/8] avformat/imf_cpl: fix indention after previous commit Michael Niedermayer
2025-05-11  0:32 ` [FFmpeg-devel] [PATCH 5/8] avcodec/aacsbr_template: Check ilb Michael Niedermayer
2025-05-11  0:32 ` [FFmpeg-devel] [PATCH 6/8] avcodec/sonic: Check num_taps Michael Niedermayer
2025-05-11  0:32 ` Michael Niedermayer [this message]
2025-05-14 16:34   ` [FFmpeg-devel] [PATCH 7/8] avcodec/svq3: Check that for 8 byte space before subtracting Andreas Rheinhardt
2025-05-14 23:24     ` Michael Niedermayer
2025-05-15  0:05       ` Andreas Rheinhardt
2025-05-11  0:32 ` [FFmpeg-devel] [PATCH 8/8] avcodec/svq3: Check there are bits left before decompression Michael Niedermayer
2025-05-14 23:27 ` [FFmpeg-devel] [PATCH 1/8] avcodec/dnxuc_parser: Use ff_parse_close() Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250511003245.413345-7-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git