From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2FC324E9CE for ; Sat, 10 May 2025 15:19:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A6CA768CA72; Sat, 10 May 2025 18:19:53 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 08AE368C417 for ; Sat, 10 May 2025 18:19:46 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 32E131FCED for ; Sat, 10 May 2025 15:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1746890386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LIepKmh/Qi41svhQV9tbOH67f9fKXHaTIeSJiN+qacM=; b=DvnQjNaz5AIIUvdXiahJz/WmC1EKpQDVWP3UgZsHwm7TvEdmLwfKPRBsO0YjmAY87PXwxo taoSwYnVWd8gE62XOuR6KQQZ2e54QDsIamqjXdAXKoG7Pum9PxH8YS+cyYqjAZfhHtpvxG DbGcAZuvS3K3CJcP6UQNFcA0RafmX9ndb9U/Pv0uDN4kfA/dip2C+X7B0eZ62pUVLpv5FL venPxlp0t7uBevZmbTmheU+RJPfNPHCUxIcm8CM3tbUEhKBwByDZJzXSXS91lDzHDgHELD +DhcsVmPK7DL36RCy1APYKPFNmnxb1CYdpRe22Xlum6XNT47wR0aeha8S2pmqA== Date: Sat, 10 May 2025 17:19:45 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250510151945.GU29660@pb2> References: <20250508222805.26361-1-cus@passwd.hu> <20250509092108.GP29660@pb2> <1a1435b6-04d1-75de-47ae-f38fd23f0964@passwd.hu> MIME-Version: 1.0 In-Reply-To: <1a1435b6-04d1-75de-47ae-f38fd23f0964@passwd.hu> X-GND-State: clean X-GND-Score: -90 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvleehkeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculddutddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeffledtfeevfeffheeuuefhtdejieelueeftdeitdfgheetgefffeefteekffdthfenucffohhmrghinhepfhhfmhhpvghgrdhorhhgnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/wavdec: increase requested probe score for codec probe X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7958476349454500815==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7958476349454500815== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eNjIDde0W37E3OQP" Content-Disposition: inline --eNjIDde0W37E3OQP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 09, 2025 at 01:54:22PM +0200, Marton Balint wrote: >=20 >=20 > On Fri, 9 May 2025, Michael Niedermayer wrote: >=20 > > On Fri, May 09, 2025 at 12:28:00AM +0200, Marton Balint wrote: > > > Codec probing was primarily added to the wav demuxer to support DTS-i= n-wav > > > files, but DTS probing functions return AVPROBE_SCORE_EXTENSION+1, so= we can be > > > a bit more strict with the required score. > > >=20 > > > This fixes MP3 misdetections for some wav files. > > >=20 > > > Fixes ticket #11581. > > >=20 > > > Signed-off-by: Marton Balint > > > --- > > > libavformat/wavdec.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c > > > index dc7e49abc4..c65e0a2723 100644 > > > --- a/libavformat/wavdec.c > > > +++ b/libavformat/wavdec.c > > > @@ -178,7 +178,7 @@ static void handle_stream_probing(AVStream *st) > > > { > > > if (st->codecpar->codec_id =3D=3D AV_CODEC_ID_PCM_S16LE) { > > > FFStream *const sti =3D ffstream(st); > > > - sti->request_probe =3D AVPROBE_SCORE_EXTENSION; > > > + sti->request_probe =3D AVPROBE_SCORE_EXTENSION + 1; > > > sti->probe_packets =3D FFMIN(sti->probe_packets, 32); > > > } > > > } > >=20 > > please add a testcase to fate, if possible. Such corner cases > > are important to be in fate >=20 > Sample is in the ticket, so it should be pretty trivial to do so. Can't we > fund someone to do this and the other fixed trac tickets without fate tes= ts? Iam in favor of funding that see https://trac.ffmpeg.org/wiki/SponsoringPrograms/STF/2025 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2 --eNjIDde0W37E3OQP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaB9ujQAKCRBhHseHBAsP qw+pAJ4n5s4TDdpu5jT0AR4XtE0ZEO4yMwCeJuDaao4Abteudo1AvtvHOp9CvuI= =BUM2 -----END PGP SIGNATURE----- --eNjIDde0W37E3OQP-- --===============7958476349454500815== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7958476349454500815==--