From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3B7604C6EF for ; Fri, 9 May 2025 09:21:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2190068C023; Fri, 9 May 2025 12:21:17 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 68CD368C023 for ; Fri, 9 May 2025 12:21:10 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 451BF4327D for ; Fri, 9 May 2025 09:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1746782469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I7ZJQ7aB2+cbwwShaesYUKv4gdHYzPoAPVtLNK1KGP0=; b=ohyT6rUE3JaCV18rOIIZRqS9Xmi0Pcnh6mU/a7Pq9HEv5Obngios4uWcVb/f0YWVLBLOsC fAcnao5XCUGX/x3seOSLRwE5PzijaCFQyxIpLsoy//6a+Aug56ao9n1c3rXPVd/NPn5skU HUJWFk6Lu2OWznOq7hG7qql9TL2BTXLVwSSOt9DKGwm8h6OSsc296CNbhmI1Yu5hCF/GJw qNhR750NzMCBlE87TyWs+OvY0j1zW6Ku0aC89YqKLFJYvcHa72wMqKUMe/Dpk7Mq9//ZJG UfEYwpZqpm8YO+F+GBVfND29HsdofVDbJWRXZ/KQuZUxuhvrnUmVkwzGAVvZdg== Date: Fri, 9 May 2025 11:21:08 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250509092108.GP29660@pb2> References: <20250508222805.26361-1-cus@passwd.hu> MIME-Version: 1.0 In-Reply-To: <20250508222805.26361-1-cus@passwd.hu> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvledvvdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/wavdec: increase requested probe score for codec probe X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4979288140481929360==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4979288140481929360== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0UhZIN3Sa23/ILEd" Content-Disposition: inline --0UhZIN3Sa23/ILEd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 09, 2025 at 12:28:00AM +0200, Marton Balint wrote: > Codec probing was primarily added to the wav demuxer to support DTS-in-wav > files, but DTS probing functions return AVPROBE_SCORE_EXTENSION+1, so we = can be > a bit more strict with the required score. >=20 > This fixes MP3 misdetections for some wav files. >=20 > Fixes ticket #11581. >=20 > Signed-off-by: Marton Balint > --- > libavformat/wavdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c > index dc7e49abc4..c65e0a2723 100644 > --- a/libavformat/wavdec.c > +++ b/libavformat/wavdec.c > @@ -178,7 +178,7 @@ static void handle_stream_probing(AVStream *st) > { > if (st->codecpar->codec_id =3D=3D AV_CODEC_ID_PCM_S16LE) { > FFStream *const sti =3D ffstream(st); > - sti->request_probe =3D AVPROBE_SCORE_EXTENSION; > + sti->request_probe =3D AVPROBE_SCORE_EXTENSION + 1; > sti->probe_packets =3D FFMIN(sti->probe_packets, 32); > } > } please add a testcase to fate, if possible. Such corner cases are important to be in fate thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato=20 --0UhZIN3Sa23/ILEd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaB3I/AAKCRBhHseHBAsP qyM1AJ9caZHU8y0L1EUx/uidVAhUxikwqQCfdsWH4cBsFk3GJ3R4Rd9X2YUW7BM= =dwK/ -----END PGP SIGNATURE----- --0UhZIN3Sa23/ILEd-- --===============4979288140481929360== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4979288140481929360==--