From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1644A4E8D8 for ; Thu, 8 May 2025 11:38:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9085268C1FD; Thu, 8 May 2025 14:38:03 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C4A568BCB0 for ; Thu, 8 May 2025 14:37:57 +0300 (EEST) Received: from haasn.dev (unknown [10.30.1.1]) by haasn.dev (Postfix) with UTF8SMTP id 6EC8A406F9; Thu, 8 May 2025 13:37:56 +0200 (CEST) Date: Thu, 8 May 2025 13:37:56 +0200 Message-ID: <20250508133756.GB21744@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20250426175603.726924-8-ffmpeg@haasn.xyz> References: <20250426175603.726924-1-ffmpeg@haasn.xyz> <20250426175603.726924-8-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH 07/17] swscale: add SWS_EXPERIMENTAL flag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 26 Apr 2025 19:41:11 +0200 Niklas Haas wrote: > From: Niklas Haas > > Give users and developers a way to opt in to the new format conversion code, > and more code from the swscale rewrite in general. This conflicts with the existing option "experimental" mapped to SWS_X ("experimental" scaler). So we need to find a new name for it. I also propose that we deprecate SWS_X, perhaps alongside other obscure and less useful options like a_dither and x_dither. > --- > doc/APIchanges | 3 +++ > doc/scaler.texi | 3 +++ > libswscale/options.c | 1 + > libswscale/swscale.h | 7 +++++++ > libswscale/version.h | 2 +- > 5 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 22aa6fa5c7..84bc721569 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2025-03-28 > > API changes, most recent first: > > +2025-04-xx - xxxxxxxxxx - lsws 9.1.100 - swscale.h > + Add SWS_EXPERIMENTAL flag. > + > 2025-04-16 - c818c67991 - libpostproc 59.1.100 - postprocess.h > Deprecate PP_CPU_CAPS_3DNOW. > > diff --git a/doc/scaler.texi b/doc/scaler.texi > index eb045de6b7..519a83b5d3 100644 > --- a/doc/scaler.texi > +++ b/doc/scaler.texi > @@ -68,6 +68,9 @@ Select full chroma input. > > @item bitexact > Enable bitexact output. > + > +@item experimental > +Allow the use of experimental new code. For testing only. > @end table > > @item srcw @var{(API only)} > diff --git a/libswscale/options.c b/libswscale/options.c > index feecae8c89..044c7c7f0b 100644 > --- a/libswscale/options.c > +++ b/libswscale/options.c > @@ -50,6 +50,7 @@ static const AVOption swscale_options[] = { > { "full_chroma_inp", "full chroma input", 0, AV_OPT_TYPE_CONST, { .i64 = SWS_FULL_CHR_H_INP }, .flags = VE, .unit = "sws_flags" }, > { "bitexact", "bit-exact mode", 0, AV_OPT_TYPE_CONST, { .i64 = SWS_BITEXACT }, .flags = VE, .unit = "sws_flags" }, > { "error_diffusion", "error diffusion dither", 0, AV_OPT_TYPE_CONST, { .i64 = SWS_ERROR_DIFFUSION}, .flags = VE, .unit = "sws_flags" }, > + { "experimental", "allow experimental new code", 0, AV_OPT_TYPE_CONST, { .i64 = SWS_EXPERIMENTAL }, .flags = VE, .unit = "sws_flags" }, > > { "param0", "scaler param 0", OFFSET(scaler_params[0]), AV_OPT_TYPE_DOUBLE, { .dbl = SWS_PARAM_DEFAULT }, INT_MIN, INT_MAX, VE }, > { "param1", "scaler param 1", OFFSET(scaler_params[1]), AV_OPT_TYPE_DOUBLE, { .dbl = SWS_PARAM_DEFAULT }, INT_MIN, INT_MAX, VE }, > diff --git a/libswscale/swscale.h b/libswscale/swscale.h > index b04aa182d2..82a69e97fc 100644 > --- a/libswscale/swscale.h > +++ b/libswscale/swscale.h > @@ -155,6 +155,13 @@ typedef enum SwsFlags { > SWS_ACCURATE_RND = 1 << 18, > SWS_BITEXACT = 1 << 19, > > + /** > + * Allow using experimental new code paths. This may be faster, slower, > + * or produce different output, with semantics subject to change at any > + * point in time. For testing and debugging purposes only. > + */ > + SWS_EXPERIMENTAL = 1 << 20, > + > /** > * Deprecated flags. > */ > diff --git a/libswscale/version.h b/libswscale/version.h > index 148efd83eb..4e54701aba 100644 > --- a/libswscale/version.h > +++ b/libswscale/version.h > @@ -28,7 +28,7 @@ > > #include "version_major.h" > > -#define LIBSWSCALE_VERSION_MINOR 0 > +#define LIBSWSCALE_VERSION_MINOR 1 > #define LIBSWSCALE_VERSION_MICRO 100 > > #define LIBSWSCALE_VERSION_INT AV_VERSION_INT(LIBSWSCALE_VERSION_MAJOR, \ > -- > 2.49.0 > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".