From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D26834E79A for ; Wed, 7 May 2025 13:14:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4F5BB68A0C5; Wed, 7 May 2025 16:14:36 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7104468A0C5 for ; Wed, 7 May 2025 16:14:29 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B58AD43996 for ; Wed, 7 May 2025 13:14:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1746623668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jopmq82nEBK9DmkbE7n6wxt2yWIh8RqtHRgVBJqDTVc=; b=mHedBLyURF3HHmGvwL6vlbYQtFKB5QbRlzRPkZ0MrAV8E3LcBI3sIRf/WhpGwWWxEFJc9U gbQE1HDRpF22f+cCMV4VutGQkosGENzzD/wa2FCIt95B8VjGgmYmgNTDdlEJs6wCxxXIyZ XxmFb0EjRIPD7UcGvZUoNGZ3WusaNazBjXriz5VT05tLcTx5GhXKNnTW8H2332B5vMHMbW ANDNqz6YMHlhO35Nlxu3mauDBHRs94QtVhY5CiWB1Wzw/sOkM8WngTUWvIbww5tMl28QDU 3D2IB9Bwnt3e36NJNwHKNmXMaLw0IVjjezud8Q97Locs3Hc8P230xb1ia7637w== Date: Wed, 7 May 2025 15:14:27 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250507131427.GK29660@pb2> References: <20250506141932.73142-1-romain.beauxis@gmail.com> <20250506141932.73142-6-romain.beauxis@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250506141932.73142-6-romain.beauxis@gmail.com> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvkeeileehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v4 5/6] ogg/vorbis: implement header packet skip in chained ogg bitstreams. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7793895749960126734==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7793895749960126734== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aqWxf8ydqYKP8htK" Content-Disposition: inline --aqWxf8ydqYKP8htK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 06, 2025 at 09:19:31AM -0500, Romain Beauxis wrote: > --- > libavformat/oggparsevorbis.c | 11 +++++++++-- > tests/ref/fate/ogg-vorbis-chained-meta.txt | 3 --- > 2 files changed, 9 insertions(+), 5 deletions(-) >=20 > diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c > index 9f50ab9ffc..8b4ae872d2 100644 > --- a/libavformat/oggparsevorbis.c > +++ b/libavformat/oggparsevorbis.c > @@ -418,6 +418,7 @@ static int vorbis_packet(AVFormatContext *s, int idx) > struct ogg_stream *os =3D ogg->streams + idx; > struct oggvorbis_private *priv =3D os->private; > int duration, flags =3D 0; > + int skip_packet =3D 0; > =20 > if (!priv->vp) > return AVERROR_INVALIDDATA; > @@ -480,7 +481,13 @@ static int vorbis_packet(AVFormatContext *s, int idx) > if (duration < 0) { > os->pflags |=3D AV_PKT_FLAG_CORRUPT; > return 0; > - } else if (flags & VORBIS_FLAG_COMMENT) { > + } > + > + if (flags & > + (VORBIS_FLAG_HEADER | VORBIS_FLAG_COMMENT | VORBIS_FLAG_SETU= P)) > + skip_packet =3D 1; can the content of the header containing "global" tables for vorbis change? if so what does this patch do to such a stream ? (I mean is this breaking such streams? or do they not exist or did that nev= er work?) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred thousand innocent people, expect your government to call the consequence "unprovoked inhuman terrorist attacks" and use it to justify dropping more bombs and killing more people. The technology changed, the idea is old. --aqWxf8ydqYKP8htK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaBtcqAAKCRBhHseHBAsP q9OOAJ9YO6tYSdY7NMW5RMCx38ct2LSEsgCeIo6qAjrI/Hrqw63pdzxMb+mQtCE= =5Bhp -----END PGP SIGNATURE----- --aqWxf8ydqYKP8htK-- --===============7793895749960126734== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7793895749960126734==--