From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 2A7F24C5DD
	for <ffmpegdev@gitmailbox.com>; Tue,  6 May 2025 21:26:23 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF60B68B7CC;
	Wed,  7 May 2025 00:26:19 +0300 (EEST)
Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net
 [217.70.183.200])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E4852687DA6
 for <ffmpeg-devel@ffmpeg.org>; Wed,  7 May 2025 00:26:12 +0300 (EEST)
Received: by mail.gandi.net (Postfix) with ESMTPSA id EF260438F8
 for <ffmpeg-devel@ffmpeg.org>; Tue,  6 May 2025 21:26:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1746566772;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=DyQURz9OINP5sIZIReVG9X7CvEsNfgNA815nkp3Rzuk=;
 b=i0i2hIPWkBAjUPdYt/tqcsaj4psz3yp4Ol5Hp9knJBIW/reLQK4WMOYhjUc4s/cySp5+zm
 nvhKlxqxW1TQiND48+on2+K9mHFXvKqteRJeUP+spQowy3dVNKi7kO6oI7qN2pciM5b8Yl
 oLe74jQL+S6/bbNfLLJFkFAMXzUSIid+6LNbfME93FvySApakcl7LiH7H+pqB0Lqa+Haoh
 e9JUGCKb9Zb9XR4v/DYnuAUuQD2fpq7Hds0j2JD34y67V+S+MjVU+Rscmbp7bsIRBXdseM
 9K+vr4mhJvteAkIpIlhSCPDNbQiIQXbPZsIah8Nc8VMEsQdf+PkihhQSQyEXag==
Date: Tue, 6 May 2025 23:26:10 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20250506212610.GH29660@pb2>
References: <20250505194406.2847-1-jamrial@gmail.com>
 <20250506204403.GG29660@pb2>
 <8a47551a-4162-4ce5-b6ca-04373fb33038@gmail.com>
MIME-Version: 1.0
In-Reply-To: <8a47551a-4162-4ce5-b6ca-04373fb33038@gmail.com>
X-GND-State: clean
X-GND-Score: -85
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvkeehtdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH] tests/fate/image: add a test for
 half-float dwab compressed stream
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============3147004432857133046=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250506212610.GH29660@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============3147004432857133046==
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GBDnBH7+ZvLx8QD4"
Content-Disposition: inline


--GBDnBH7+ZvLx8QD4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 06, 2025 at 06:10:22PM -0300, James Almer wrote:
> On 5/6/2025 5:44 PM, Michael Niedermayer wrote:
> > On Mon, May 05, 2025 at 04:44:06PM -0300, James Almer wrote:
> > > Signed-off-by: James Almer <jamrial@gmail.com>
> > > ---
> > >   tests/fate/image.mak                        | 3 +++
> > >   tests/ref/fate/rgb-scanline-dwab-half-float | 6 ++++++
> > >   2 files changed, 9 insertions(+)
> > >   create mode 100644 tests/ref/fate/rgb-scanline-dwab-half-float
> > >=20
> > > diff --git a/tests/fate/image.mak b/tests/fate/image.mak
> > > index 042cf6438f..abf204f69f 100644
> > > --- a/tests/fate/image.mak
> > > +++ b/tests/fate/image.mak
> > > @@ -124,6 +124,9 @@ fate-exr-rgb-scanline-pxr24-float-12x8: CMD =3D f=
ramecrc -i $(TARGET_SAMPLES)/exr/
> > >   FATE_EXR +=3D fate-exr-rgba-multiscanline-half-b44
> > >   fate-exr-rgba-multiscanline-half-b44: CMD =3D framecrc -i $(TARGET_=
SAMPLES)/exr/rgba_multiscanline_half_b44.exr -vf scale -pix_fmt gbrapf32le
> > > +FATE_EXR +=3D fate-rgb-scanline-dwab-half-float
> > > +fate-rgb-scanline-dwab-half-float: CMD =3D framecrc -i $(TARGET_SAMP=
LES)/exr/rgb_scanline_dwab_half_float.exr -vf scale -pix_fmt gbrpf32le
> > > +
> > >   FATE_EXR +=3D fate-exr-rgb-scanline-float-b44
> > >   fate-exr-rgb-scanline-float-b44: CMD =3D framecrc -i $(TARGET_SAMPL=
ES)/exr/rgb_scanline_float_b44.exr -vf scale -pix_fmt gbrpf32le
> > > diff --git a/tests/ref/fate/rgb-scanline-dwab-half-float b/tests/ref/=
fate/rgb-scanline-dwab-half-float
> > > new file mode 100644
> > > index 0000000000..a5a1997785
> > > --- /dev/null
> > > +++ b/tests/ref/fate/rgb-scanline-dwab-half-float
> > > @@ -0,0 +1,6 @@
> > > +#tb 0: 1/25
> > > +#media_type 0: video
> > > +#codec_id 0: rawvideo
> > > +#dimensions 0: 512x512
> > > +#sar 0: 1/1
> > > +0,          0,          0,        1,  3145728, 0xbb11b00a
> >=20
> > differnt result here: (on linux x86-64)
> >=20
> > --- ./tests/ref/fate/rgb-scanline-dwab-half-float	2025-05-06 22:40:40.0=
17406113 +0200
> > +++ tests/data/fate/rgb-scanline-dwab-half-float	2025-05-06 22:40:53.29=
7513198 +0200
> > @@ -3,4 +3,4 @@
> >   #codec_id 0: rawvideo
> >   #dimensions 0: 512x512
> >   #sar 0: 1/1
> > -0,          0,          0,        1,  3145728, 0xbb11b00a
> > +0,          0,          0,        1,  3145728, 0x2a15f7aa
> > Test rgb-scanline-dwab-half-float failed. Look at tests/data/fate/rgb-s=
canline-dwab-half-float.err for details.
>=20
> Yeah, I can reproduce it, and even if i add "sws_flags
> +accurate_rnd+bitexact" i get the same results (0xbb11b00a on Win64,
> 0x2a15f7aa on Linux x86-64). I also get a different hash in both targets =
if
> i don't rescale to gbrpf32, so the problem is not in swscale.
>=20
> Neither Valgrind or gcc-usan complain, so I'm not sure what could be
> producing this difference.

float is not bitexact in C, and float on x86 might use old x87 style while
x86-64 might be SSE*/AVX, so if theres any float in the code slight differe=
nces
can happen, no idea if half float in this case is affected by this or not

thx

[...]

--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable

--GBDnBH7+ZvLx8QD4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaBp+bwAKCRBhHseHBAsP
q67cAJ9vtVpQ/8tKpiiU0tEQMnn2nh1BywCfR3fSeNn9jdqS+Hl1Gs9oaWoVKIs=
=i10c
-----END PGP SIGNATURE-----

--GBDnBH7+ZvLx8QD4--

--===============3147004432857133046==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============3147004432857133046==--