From: Mark Thompson <sw@jkqxz.net> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 2/6] apv_decode: Fix memory leak on decode error Date: Sat, 3 May 2025 18:55:18 +0100 Message-ID: <20250503175527.1517092-2-sw@jkqxz.net> (raw) In-Reply-To: <20250503175527.1517092-1-sw@jkqxz.net> --- libavcodec/apv_decode.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/apv_decode.c b/libavcodec/apv_decode.c index b1e1db7d64..2a59c9b25d 100644 --- a/libavcodec/apv_decode.c +++ b/libavcodec/apv_decode.c @@ -377,7 +377,7 @@ static int apv_decode_frame(AVCodecContext *avctx, AVFrame *frame, case APV_PBU_PRIMARY_FRAME: err = apv_decode(avctx, frame, pbu->content); if (err < 0) - return err; + goto fail; *got_frame = 1; break; case APV_PBU_METADATA: @@ -412,8 +412,11 @@ static int apv_decode_frame(AVCodecContext *avctx, AVFrame *frame, } ff_cbs_fragment_reset(au); - return packet->size; + +fail: + ff_cbs_fragment_reset(au); + return err; } const FFCodec ff_apv_decoder = { -- 2.47.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-03 17:56 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-05-03 17:55 [FFmpeg-devel] [PATCH 1/6] cbs_apv: Always restore tracing state on split fragment error Mark Thompson 2025-05-03 17:55 ` Mark Thompson [this message] 2025-05-03 22:46 ` [FFmpeg-devel] [PATCH 2/6] apv_decode: Fix memory leak on decode error James Almer 2025-05-05 16:34 ` Mark Thompson 2025-05-03 17:55 ` [FFmpeg-devel] [PATCH 3/6] apv_decode: Improve reporting of decode errors Mark Thompson 2025-05-03 22:49 ` James Almer 2025-05-03 17:55 ` [FFmpeg-devel] [PATCH 4/6] cbs_apv: Better constrain tile_width/height_in_mbs Mark Thompson 2025-05-03 17:55 ` [FFmpeg-devel] [PATCH 5/6] apv_entropy: Improve robustness to bitstream errors Mark Thompson 2025-05-03 17:55 ` [FFmpeg-devel] [PATCH 6/6] cbs_apv: Check tile component sizes Mark Thompson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250503175527.1517092-2-sw@jkqxz.net \ --to=sw@jkqxz.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git