Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Romain Beauxis <romain.beauxis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Romain Beauxis <romain.beauxis@gmail.com>
Subject: [FFmpeg-devel] [PATCH v3 0/2] Remove chained ogg stream header packets from demuxer
Date: Sat,  3 May 2025 12:03:27 -0500
Message-ID: <20250503170329.46135-1-romain.beauxis@gmail.com> (raw)

These patches remove the ogg header packets from secondary chained ogg
streams from the demuxer.

To do so, the packet demuxing function is modified to explicitely tell
the demuxer when skip header packets

Also, the opus packet demuxing function is adapted to properly copy extra
data from the new chained streams so that decoding can keep happening.

The diff from the test output makes it possible to follow what the
changes do to the extracted streams.

## Changes since last revision:
* The base tests are now in the codebase
* Split the last commit in two, one for the API change and one for the
  corresponding codec-specific use of it.

Romain Beauxis (2):
  libavformat/oggdec.c: Changing the packet() callback API/Return value
  ogg/{vorbis,flac,opus}: Remove header packets from subsequent ogg
    streams from the demuxer output.

 libavformat/oggdec.c                       | 26 ++++++++++----------
 libavformat/oggdec.h                       |  6 +++++
 libavformat/oggparseflac.c                 | 28 ++++++++++++++++++++--
 libavformat/oggparseopus.c                 | 11 +++++++++
 libavformat/oggparsevorbis.c               | 11 +++++++--
 tests/ref/fate/ogg-flac-chained-meta.txt   |  2 --
 tests/ref/fate/ogg-opus-chained-meta.txt   |  1 -
 tests/ref/fate/ogg-vorbis-chained-meta.txt |  3 ---
 8 files changed, 66 insertions(+), 22 deletions(-)

-- 
2.39.5 (Apple Git-154)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2025-05-03 17:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-03 17:03 Romain Beauxis [this message]
2025-05-03 17:03 ` [FFmpeg-devel] [PATCH v3 1/2] libavformat/oggdec.c: Changing the packet() callback API/Return value Romain Beauxis
2025-05-04 14:04   ` Michael Niedermayer
2025-05-04 16:42     ` Romain Beauxis
2025-05-04 22:23       ` Michael Niedermayer
2025-05-06 14:20         ` Romain Beauxis
2025-05-03 17:03 ` [FFmpeg-devel] [PATCH v3 2/2] ogg/{vorbis, flac, opus}: Remove header packets from subsequent ogg streams from the demuxer output Romain Beauxis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250503170329.46135-1-romain.beauxis@gmail.com \
    --to=romain.beauxis@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git