[FFmpeg-devel] [PATCH] avfilter/vf_setparams: Fix chroma_location being cleared

[FFmpeg-devel] [PATCH] avfilter/vf_setparams: Fix chroma_location being cleared

[Tobias Rapp]

Fix chroma_location being cleared by setrange and setfield filters.
This was forgotten in 201f1cba150d44de6fedfeee4e8647170ed5fbca.

Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
---
 libavfilter/vf_setparams.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c
index 751750e..1e37876 100644
--- a/libavfilter/vf_setparams.c
+++ b/libavfilter/vf_setparams.c
@@ -236,6 +236,7 @@ static av_cold int init_setrange(AVFilterContext *ctx)
     s->color_primaries = -1;
     s->color_trc       = -1;
     s->colorspace      = -1;
+    s->chroma_location = -1;
     return 0;
 }
 
@@ -272,6 +273,7 @@ static av_cold int init_setfield(AVFilterContext *ctx)
     s->color_primaries = -1;
     s->color_trc       = -1;
     s->colorspace      = -1;
+    s->chroma_location = -1;
     return 0;
 }
 
-- 
2.7.4

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_setparams: Fix chroma_location being cleared

[Tobias Rapp]

On 30/04/2025 14:09, Tobias Rapp wrote:

> Fix chroma_location being cleared by setrange and setfield filters.
> This was forgotten in 201f1cba150d44de6fedfeee4e8647170ed5fbca.
>
> Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
> ---
>   libavfilter/vf_setparams.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c
> index 751750e..1e37876 100644
> --- a/libavfilter/vf_setparams.c
> +++ b/libavfilter/vf_setparams.c
> @@ -236,6 +236,7 @@ static av_cold int init_setrange(AVFilterContext *ctx)
>       s->color_primaries = -1;
>       s->color_trc       = -1;
>       s->colorspace      = -1;
> +    s->chroma_location = -1;
>       return 0;
>   }
>   
> @@ -272,6 +273,7 @@ static av_cold int init_setfield(AVFilterContext *ctx)
>       s->color_primaries = -1;
>       s->color_trc       = -1;
>       s->colorspace      = -1;
> +    s->chroma_location = -1;
>       return 0;
>   }
>   

If approved, I would also like to backport the fix to the release/7.1 
branch.

Regards, Tobias

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_setparams: Fix chroma_location being cleared

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1557 bytes --]

On Wed, Apr 30, 2025 at 02:56:58PM +0200, Tobias Rapp wrote:
> On 30/04/2025 14:09, Tobias Rapp wrote:
> 
> > Fix chroma_location being cleared by setrange and setfield filters.
> > This was forgotten in 201f1cba150d44de6fedfeee4e8647170ed5fbca.
> > 
> > Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
> > ---
> >   libavfilter/vf_setparams.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c
> > index 751750e..1e37876 100644
> > --- a/libavfilter/vf_setparams.c
> > +++ b/libavfilter/vf_setparams.c
> > @@ -236,6 +236,7 @@ static av_cold int init_setrange(AVFilterContext *ctx)
> >       s->color_primaries = -1;
> >       s->color_trc       = -1;
> >       s->colorspace      = -1;
> > +    s->chroma_location = -1;
> >       return 0;
> >   }
> > @@ -272,6 +273,7 @@ static av_cold int init_setfield(AVFilterContext *ctx)
> >       s->color_primaries = -1;
> >       s->color_trc       = -1;
> >       s->colorspace      = -1;
> > +    s->chroma_location = -1;
> >       return 0;
> >   }
> 
> If approved, I would also like to backport the fix to the release/7.1
> branch.

backport ok
201f1cba150d44de6fedfeee4e8647170ed5fbca is niklas change so, give him a
bit time to reply but it looks like this was forgotten i agree

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_setparams: Fix chroma_location being cleared

[Tobias Rapp]

On 02/05/2025 22:08, Michael Niedermayer wrote:

> On Wed, Apr 30, 2025 at 02:56:58PM +0200, Tobias Rapp wrote:
>> On 30/04/2025 14:09, Tobias Rapp wrote:
>>
>>> Fix chroma_location being cleared by setrange and setfield filters.
>>> This was forgotten in 201f1cba150d44de6fedfeee4e8647170ed5fbca.
>>>
>>> Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
>>> ---
>>>    libavfilter/vf_setparams.c | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c
>>> index 751750e..1e37876 100644
>>> --- a/libavfilter/vf_setparams.c
>>> +++ b/libavfilter/vf_setparams.c
>>> @@ -236,6 +236,7 @@ static av_cold int init_setrange(AVFilterContext *ctx)
>>>        s->color_primaries = -1;
>>>        s->color_trc       = -1;
>>>        s->colorspace      = -1;
>>> +    s->chroma_location = -1;
>>>        return 0;
>>>    }
>>> @@ -272,6 +273,7 @@ static av_cold int init_setfield(AVFilterContext *ctx)
>>>        s->color_primaries = -1;
>>>        s->color_trc       = -1;
>>>        s->colorspace      = -1;
>>> +    s->chroma_location = -1;
>>>        return 0;
>>>    }
>> If approved, I would also like to backport the fix to the release/7.1
>> branch.
> backport ok
> 201f1cba150d44de6fedfeee4e8647170ed5fbca is niklas change so, give him a
> bit time to reply but it looks like this was forgotten i agree

Pushed to master and backported to release/7.1.

Regards, Tobias

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".