Re: [FFmpeg-devel] [PATCH 16/17] swscale/format: add new format decode/encode logic

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 16/17] swscale/format: add new format decode/encode logic
Date: Fri, 2 May 2025 16:10:57 +0200
Message-ID: <20250502141057.GY4991@pb2> (raw)
In-Reply-To: <20250426175603.726924-17-ffmpeg@haasn.xyz>

[-- Attachment #1.1: Type: text/plain, Size: 1708 bytes --]

On Sat, Apr 26, 2025 at 07:41:20PM +0200, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> This patch adds format handling code for the new operations. This entails
> fully decoding a format to standardized RGB, and the inverse.
> 
> Handling it this way means we can always guarantee that a conversion path
> exists from A to B without having to explicitly cover logic for each path;
> and choosing RGB instead of YUV as the intermediate (as was done in swscale
> v1) is more flexible with regards to enabling further operations such as
> primaries conversions, linear scaling, etc.
> 
> In the case of YUV->YUV transform, the redundant matrix multiplication will
> be canceled out anyways.
> ---
>  libswscale/format.c | 925 ++++++++++++++++++++++++++++++++++++++++++++
>  libswscale/format.h |  23 ++
>  2 files changed, 948 insertions(+)

this or rather the equivalent from your repo breaks here:

In file included from libswscale/ops.h:24,
                 from libswscale/ops_internal.h:26,
                 from libswscale/format.c:28:
libswscale/format.c: In function ‘trc_is_hdr’:
libswscale/format.c:1249:9: error: a label can only be part of a statement and a declaration is not a statement
 1249 |         static_assert(AVCOL_TRC_NB == 19, "Update this list when adding TRCs");
      |         ^~~~~~~~~~~~~
make: *** [ffbuild/common.mak:81: libswscale/format.o] Error 1
make: *** Waiting for unfinished jobs....

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Some people wanted to paint the bikeshed green, some blue and some pink.
People argued and fought, when they finally agreed, only rust was left.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".