Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] avformat/apvdec: also look for an au_info PBU during probing
Date: Thu,  1 May 2025 14:49:48 -0300
Message-ID: <20250501174948.2953-1-jamrial@gmail.com> (raw)

If present, an Access unit information PBU must be the first in an AU.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/apvdec.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/libavformat/apvdec.c b/libavformat/apvdec.c
index 5d0b11b654..e53c9ed085 100644
--- a/libavformat/apvdec.c
+++ b/libavformat/apvdec.c
@@ -51,7 +51,24 @@ static int apv_extract_header_info(GetByteContext *gbc)
     if (zero != 0)
         return AVERROR_INVALIDDATA;
 
-    if (info->pbu_type != APV_PBU_PRIMARY_FRAME)
+    if (info->pbu_type == APV_PBU_ACCESS_UNIT_INFORMATION) {
+        unsigned int num_frames = bytestream2_get_be16(gbc);
+        int pbu_type;
+
+        if (num_frames < 1)
+            return AVERROR_INVALIDDATA;
+
+        info->pbu_type = bytestream2_get_byte(gbc);
+        if (info->pbu_type != APV_PBU_PRIMARY_FRAME &&
+            info->pbu_type != APV_PBU_NON_PRIMARY_FRAME &&
+            (info->pbu_type < APV_PBU_PREVIEW_FRAME || info->pbu_type > APV_PBU_ALPHA_FRAME))
+            return AVERROR_INVALIDDATA;
+
+        bytestream2_skip(gbc, 2); // group_id
+        zero = bytestream2_get_byte(gbc);
+        if (zero != 0)
+            return AVERROR_INVALIDDATA;
+    } else if (info->pbu_type != APV_PBU_PRIMARY_FRAME)
         return AVERROR_INVALIDDATA;
 
     info->profile_idc = bytestream2_get_byte(gbc);
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2025-05-01 17:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-01 17:49 James Almer [this message]
2025-05-04 14:01 ` James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250501174948.2953-1-jamrial@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git