From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 7D9784BD31 for ; Tue, 29 Apr 2025 13:01:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4EBFE68A59A; Tue, 29 Apr 2025 16:00:59 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5180B687DED for ; Tue, 29 Apr 2025 16:00:52 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 73A4A439FC for ; Tue, 29 Apr 2025 13:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1745931651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=khQ3bDF75AWaRwcBNfZGtXKhxM/mJAGGYYErxh6RKcY=; b=A3OjMYrxouTb84GIlbflytqsYvEse4V0AXit++s93hOIb5hZEDTucF4WbHUlEIUx9G8f/B dO7ZCniDHtEsuOyizJ5bcG+szgR++s4UvpztIKcCLvKAKZcoEYgIa2HNg96g7YH+zRu2y8 RB1XLqyFyE0OzC4iWfQiiQnzIBg30wieIbgKUn5Xzm7KCK1GFyb/22tHNFE0UKcf8kXzVs Pi8NtbxG2okYnDatFBfvuLhk/nIi4SE/XGeuhJnpoz/JN7mRMNG1pfwSiuVIY0asg6iSMB sVkWOLjli4RfABtampoODyKSQ5lVLQ69WVKqpGISd4AndU2j0EDUsCn9TjEWiw== Date: Tue, 29 Apr 2025 15:00:50 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250429130050.GM4991@pb2> References: <20250426175603.726924-1-ffmpeg@haasn.xyz> <20250426175603.726924-12-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20250426175603.726924-12-ffmpeg@haasn.xyz> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvieefkeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 11/17] swscale/x86: add SIMD backend X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7666204079105516560==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7666204079105516560== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uwQ+6ZYibwGg4bSi" Content-Disposition: inline --uwQ+6ZYibwGg4bSi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 26, 2025 at 07:41:15PM +0200, Niklas Haas wrote: > From: Niklas Haas >=20 > This covers most 8-bit and 16-bit ops, and some 32-bit ops. It also cover= s all > floating point operations. While this is not yet 100% coverage, it's good > enough for the vast majority of formats out there. >=20 > Of special note is the packed shuffle solver, which can reduce any compat= ible > series of operations down to a single pshufb loop. This takes care of any= sort > of packed swizzle, but also e.g. grayscale to packed RGB expansion, RGB b= it > depth conversions, endianness swapping and so on. > --- > libswscale/ops.c | 4 + > libswscale/x86/Makefile | 3 + > libswscale/x86/ops.c | 735 ++++++++++++++++++++++++++++ > libswscale/x86/ops_common.asm | 208 ++++++++ > libswscale/x86/ops_float.asm | 376 +++++++++++++++ > libswscale/x86/ops_int.asm | 882 ++++++++++++++++++++++++++++++++++ > 6 files changed, 2208 insertions(+) > create mode 100644 libswscale/x86/ops.c > create mode 100644 libswscale/x86/ops_common.asm > create mode 100644 libswscale/x86/ops_float.asm > create mode 100644 libswscale/x86/ops_int.asm breaks build: X86ASM libswscale/x86/ops_float.o libswscale/x86/ops_common.asm:180: error: unknown preprocessor directive `%= rmacro' libswscale/x86/ops_common.asm:180: error: label or instruction expected at = start of line libswscale/x86/ops_common.asm:181: error: `%1': not in a macro call libswscale/x86/ops_common.asm:181: error: expression syntax error libswscale/x86/ops_common.asm:182: error: `%2': not in a macro call libswscale/x86/ops_common.asm:184: error: `%endmacro': not defining a macro libswscale/x86/ops_common.asm:187: error: unknown preprocessor directive `%= rmacro' libswscale/x86/ops_common.asm:187: error: label or instruction expected at = start of line libswscale/x86/ops_common.asm:188: error: `%1': not in a macro call libswscale/x86/ops_common.asm:188: error: expression syntax error libswscale/x86/ops_common.asm:189: error: `%2': not in a macro call libswscale/x86/ops_common.asm:191: error: `%endmacro': not defining a macro libswscale/x86/ops_float.asm:369: error: parser: instruction expected libswscale/x86/ops_common.asm:99: ... from macro `decl_common_patterns' def= ined here libswscale/x86/ops_common.asm:91: ... from macro `decl_pattern' defined here libswscale/x86/ops_float.asm:31: ... from macro `conv8to32f' defined here libswscale/x86/ops_float.asm:369: error: parser: instruction expected libswscale/x86/ops_common.asm:99: ... from macro `decl_common_patterns' def= ined here libswscale/x86/ops_common.asm:91: ... from macro `decl_pattern' defined here libswscale/x86/ops_float.asm:32: ... from macro `conv8to32f' defined here libswscale/x86/ops_float.asm:369: error: parser: instruction expected libswscale/x86/ops_common.asm:99: ... from macro `decl_common_patterns' def= ined here libswscale/x86/ops_common.asm:91: ... from macro `decl_pattern' defined here [snipped a long list of similar looking errors] thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable --uwQ+6ZYibwGg4bSi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaBDNeAAKCRBhHseHBAsP q5SeAJ48oLpC2IwGdlwTi8gZaUJr153l4gCfbiCqF2niLS2dZa5pnniwqSBC+/Q= =TX9m -----END PGP SIGNATURE----- --uwQ+6ZYibwGg4bSi-- --===============7666204079105516560== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7666204079105516560==--