From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 86D114E0AF for ; Sun, 27 Apr 2025 18:50:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1700B68AE09; Sun, 27 Apr 2025 21:50:06 +0300 (EEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 38875687D47 for ; Sun, 27 Apr 2025 21:50:00 +0300 (EEST) Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-39c1ef4ae3aso2476002f8f.1 for ; Sun, 27 Apr 2025 11:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1745779799; x=1746384599; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=QYPSzIChJxR705g3yViGvCxe2A7QmimTFWlwan2uup0=; b=grviSeKUeR7xnY3NFjK+NV/5mvnH6WnKciahLG89biNjrOklJBqynWJDTpIM0kjAbA tQmnudsmtxx7XvzUe2KMj+pHX4ZSsINDna6JWQIJMqMdUzC4eqvwzYpEd3wB5Nw2pEqw fb+E0mjlfbeTXwbf8qKr1laLG554Me7C8iN86QuaIObtX5wWwruJYfSB8YDdbYWquSkk dGl0AfD7Uz8hd4gQYqmXbSy3TK6KQW/V4S7W1J0CXDZHvTpcLUquUiYifZ+2l4UKlxJz 9niwkNrO7bsMQ/BCcF8DxBD7mSrbrwKZ5fdcb0wevWOyjihaG4VKKw+O7ZL/4HeYJM0J diTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745779799; x=1746384599; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QYPSzIChJxR705g3yViGvCxe2A7QmimTFWlwan2uup0=; b=DZfemSWsDXjQkSwfnuaYf+it5koliT1gpztRje87UEO/oXerY4k9K8a7+3mPxQHJmm armNaqttQQhongt6Tok7OUuxUoodKd1ATcOpp1Lles0Vrw6mBJtvRg/GYVB0IMMdjirX Ujx1TLnD+zIPbub6dOdn1HLX9xeUmlH1Meqdg4zGxlcy/96eOVSUQPvwxf0FVPoRTOea zse0+Hc2edJbOgpjp2CdW1Nzg+K+5U86LvLZ/0BGSPv46VYCg83Yvt0OGzUNU8AldsNd gLr6XXMvtZ7Ti02Aql7dWum+xeLH1DZMjRb1HF8xBb3IL3b7cpJtjMR9OFl37o8RCqTN v5iQ== X-Gm-Message-State: AOJu0YzqYSoIz5CeRxva1zMffmHP4SYsDvvbbSr3zdz8oGdOJMzigaar ttIDg/vqkCpvhHGCQXwVxEoUPOQUSoUntoBov9zu88sSUEUDvE96267giP1VwaQRB9evlKouLQS RZeWCEQ== X-Gm-Gg: ASbGncs2aiu4KLU1Gm6oct8mkfC50XPSE/edB0jDvctv4UUP/W8yrJda5NtkjzEtxYt E54XC9Y17Ae8UeUUp+7APrBfneRXq6NZwEInqGB1vIiWIGRrO/NvKaK5kRo+BHz9M7vZCOUGrbB VNE+miMQx4zzoMOt3jynXR3A266jGrfKXf7v5F7fZqbc0jhnEK0kQqwOl/C694fWOFnGwQTMA/4 xfOoU5tbK0d15dosevkZR3O9e9Bt+t1F+Dst6zr5rKC7t61zx5RghIdevs6wGUM/5MJXqRcSHwV EFaOjrIxo8tOVSvJMuDxz5RjhKHpOoDV69otY6gyvukdVvD7LUnYdzQC8w+OzhyyNC9Ipyqklf1 Vk+c9Bjb6Ln6kDAQuqVpiju4= X-Google-Smtp-Source: AGHT+IFEkBD89uBL0hHR/BC5MaYSdaSin3Epq/QFuHdGTmKVgjQHlybAQcVwr6EpGRF+tiYpROfQiQ== X-Received: by 2002:a05:6000:18ae:b0:391:1218:d5f4 with SMTP id ffacd0b85a97d-3a074d4637dmr7049352f8f.23.1745779799506; Sun, 27 Apr 2025 11:49:59 -0700 (PDT) Received: from localhost.localdomain (cpc92320-cmbg19-2-0-cust719.5-4.cable.virginm.net. [82.13.66.208]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a07a5ed2e0sm6397063f8f.39.2025.04.27.11.49.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 11:49:58 -0700 (PDT) From: Mark Thompson To: ffmpeg-devel@ffmpeg.org Date: Sun, 27 Apr 2025 19:49:37 +0100 Message-ID: <20250427184943.505741-1-sw@jkqxz.net> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] apv_decode: Replace division with shift X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The compiler can't see that this should be a shift and generates a real division which is slow enough to appear in profiles on its own. --- libavcodec/apv_decode.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/apv_decode.c b/libavcodec/apv_decode.c index e28bc29c8f..e2c3161978 100644 --- a/libavcodec/apv_decode.c +++ b/libavcodec/apv_decode.c @@ -173,8 +173,8 @@ static int apv_decode_tile_component(AVCodecContext *avctx, void *data, const AVPixFmtDescriptor *pix_fmt_desc = av_pix_fmt_desc_get(avctx->pix_fmt); - int sub_w = comp_index == 0 ? 1 : pix_fmt_desc->log2_chroma_w + 1; - int sub_h = comp_index == 0 ? 1 : pix_fmt_desc->log2_chroma_h + 1; + int sub_w_shift = comp_index == 0 ? 0 : pix_fmt_desc->log2_chroma_w; + int sub_h_shift = comp_index == 0 ? 0 : pix_fmt_desc->log2_chroma_h; APVRawTile *tile = &input->tile[tile_index]; @@ -190,8 +190,8 @@ static int apv_decode_tile_component(AVCodecContext *avctx, void *data, int tile_mb_width = tile_width / APV_MB_WIDTH; int tile_mb_height = tile_height / APV_MB_HEIGHT; - int blk_mb_width = 2 / sub_w; - int blk_mb_height = 2 / sub_h; + int blk_mb_width = 2 >> sub_w_shift; + int blk_mb_height = 2 >> sub_h_shift; int bit_depth; int qp_shift; @@ -234,10 +234,10 @@ static int apv_decode_tile_component(AVCodecContext *avctx, void *data, for (int blk_x = 0; blk_x < blk_mb_width; blk_x++) { int frame_y = (tile_start_y + APV_MB_HEIGHT * mb_y + - APV_TR_SIZE * blk_y) / sub_h; + APV_TR_SIZE * blk_y) >> sub_h_shift; int frame_x = (tile_start_x + APV_MB_WIDTH * mb_x + - APV_TR_SIZE * blk_x) / sub_w; + APV_TR_SIZE * blk_x) >> sub_w_shift; ptrdiff_t frame_pitch = apv->output_frame->linesize[comp_index]; uint8_t *block_start = apv->output_frame->data[comp_index] + -- 2.47.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".