Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: toqsxw@gmail.com
To: ffmpeg-devel@ffmpeg.org
Cc: nuomi2021@gmail.com, Wu Jianhua <toqsxw@outlook.com>
Subject: [FFmpeg-devel] [PATCH v2 11/20] avcodec/vvcdec: verify picture hash
Date: Sun, 27 Apr 2025 19:44:41 +0800
Message-ID: <20250427114451.1236-11-toqsxw@outlook.com> (raw)
In-Reply-To: <20250427114451.1236-1-toqsxw@outlook.com>

From: Wu Jianhua <toqsxw@outlook.com>

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
---
 libavcodec/vvc/dec.c | 21 ++++++++++++++++++++-
 libavcodec/vvc/dec.h |  2 ++
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c
index 4c0d08440a..11d653e684 100644
--- a/libavcodec/vvc/dec.c
+++ b/libavcodec/vvc/dec.c
@@ -1079,7 +1079,25 @@ static int frame_end(VVCContext *s, VVCFrameContext *fc)
         }
     }
 
-    return ret;
+    if (!s->avctx->hwaccel && s->avctx->err_recognition & AV_EF_CRCCHECK) {
+        VVCSEI *sei = &fc->sei;
+        if (sei->picture_hash.present) {
+            int ret = ff_h274_hash_init(&s->hash_ctx, sei->picture_hash.hash_type);
+            if (ret < 0)
+                return ret;
+
+            ret = ff_h274_hash_verify(s->hash_ctx, &sei->picture_hash, fc->ref->frame, fc->ps.pps->width, fc->ps.pps->height);
+            if (ret < 0) {
+                av_log(s->avctx, AV_LOG_ERROR,
+                    "Verifying checksum for frame with decoder_order %d: failed\n",
+                    (int)fc->decode_order);
+                if (s->avctx->err_recognition & AV_EF_EXPLODE)
+                    return ret;
+            }
+        }
+    }
+
+    return 0;
 }
 
 static int wait_delayed_frame(VVCContext *s, AVFrame *output, int *got_output)
@@ -1207,6 +1225,7 @@ static av_cold int vvc_decode_free(AVCodecContext *avctx)
             frame_context_free(s->fcs + i);
         av_free(s->fcs);
     }
+    ff_h274_hash_freep(&s->hash_ctx);
     ff_vvc_ps_uninit(&s->ps);
     ff_cbs_close(&s->cbc);
 
diff --git a/libavcodec/vvc/dec.h b/libavcodec/vvc/dec.h
index b159863b31..5f8065b38b 100644
--- a/libavcodec/vvc/dec.h
+++ b/libavcodec/vvc/dec.h
@@ -249,6 +249,8 @@ typedef struct VVCContext {
 
     uint64_t nb_frames;     ///< processed frames
     int nb_delayed;         ///< delayed frames
+
+    H274HashContext *hash_ctx;
 }  VVCContext ;
 
 #endif /* AVCODEC_VVC_DEC_H */
-- 
2.44.0.windows.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2025-04-27 11:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-27 11:44 [FFmpeg-devel] [PATCH v2 01/20] avcodec/cbs_h2645: add cbs_sei_h274_types toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 02/20] avcodec/cbs_sei_syntax_template: add sei message film_grain_characteristics toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 03/20] avcodec/vvc: support decoding prefix and suffix nal units toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 04/20] avcodec/vvc/sei: add decode_film_grain_characteristics toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 05/20] avcodec/vvc/dec: export sei to the frame when the frame starts toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 06/20] avcodec/vvc/dec: support applying film grain by the decoder toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 07/20] avcodec/vvc/dec: support removing film grain params from side data toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 08/20] avcodec/h274: add H274SEIPictureHash struct toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 09/20] avcodec/vvc/sei: add decode_decoded_picture_hash toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 10/20] avcodec/h274: add ff_h274_hash functions toqsxw
2025-05-31 20:34   ` Andreas Rheinhardt
2025-05-31 21:46     ` [FFmpeg-devel] 回复: " Wu Jianhua
2025-04-27 11:44 ` toqsxw [this message]
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 12/20] avcodec/cbs_sei_syntax_template: add sei message sei_display_orientation toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 13/20] avcodec/vvc/sei: add decode_display_orientation toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 14/20] avcodec/vvc/sei: add decode_content_light_level_info toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 15/20] avcodec/cbs_sei_syntax_template: add sei message frame_field_information toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 16/20] avcodec/h274: add H274SEIFrameFieldInfo struct toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 17/20] avcodec/vvc/sei: add decode_frame_field_info toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 18/20] avcodec/vvc: support fields toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 19/20] avcodec/vvc/sei: add decode_ambient_viewing_environment toqsxw
2025-04-27 11:44 ` [FFmpeg-devel] [PATCH v2 20/20] avcodec/vvc/sei: add decode_mastering_display_colour_volume toqsxw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250427114451.1236-11-toqsxw@outlook.com \
    --to=toqsxw@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=nuomi2021@gmail.com \
    --cc=toqsxw@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git