From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id C978A4DFD7
	for <ffmpegdev@gitmailbox.com>; Sun, 27 Apr 2025 01:42:09 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4EA2F68B522;
	Sun, 27 Apr 2025 04:42:05 +0300 (EEST)
Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com
 [209.85.214.172])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 84C9A687C56
 for <ffmpeg-devel@ffmpeg.org>; Sun, 27 Apr 2025 04:41:58 +0300 (EEST)
Received: by mail-pl1-f172.google.com with SMTP id
 d9443c01a7336-2254e0b4b79so55017805ad.2
 for <ffmpeg-devel@ffmpeg.org>; Sat, 26 Apr 2025 18:41:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1745718116; x=1746322916; darn=ffmpeg.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:to:from:from:to:cc:subject:date:message-id
 :reply-to; bh=xPqopbOjBGQDmmcZbsEEFV96fTkWTu8dXpYi7yBWz6o=;
 b=Jo418Ovpn1G+M7rFATmOWrwRpTAUBgGOVto9c3ShayvzTFds+c/x2X60FAGRQqEXyF
 YE8nus5Lfjq0UasF0yasgb+0iqq7ajI9Fdi7jgM0n8WFXueghr3cNOCsS/mP0dQnJViB
 DYu8rX5m4LYgR73c4i1FXbvGqCvgp1C/aU402dv/uJSbv7uClmSlCFF+LN8mz0nrsuBL
 Boi8Bc40DNwht/sd3hFzn8jnO/3MR4CrtXjhwrj10dndkRucIilk0wyePTIN7+CPwZIO
 S8lTkwUJpwF9pr3347Dt2bdR4tEZ5fo3rxKRzoqOBGNtL8Se5miopjRLJ96aikNkGb8Q
 RNYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1745718116; x=1746322916;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=xPqopbOjBGQDmmcZbsEEFV96fTkWTu8dXpYi7yBWz6o=;
 b=DmUEGWT9tFPtf2vsirTMZ/WI8Ez6rjZAjeK9UK3XzSd6mTSA+tVkJIcIw1wSFTejnr
 zSdgSoOH/0s5pXzrymif1hfgyEWKTlFWjqDoaleKnaW8Wsp4uELqs7LYxg3NiQ+czKYS
 33rCpBrKZg7ZansAPCrvFvCLypqWoHXOJTBCXF3NIVURhHFDPOPCGhiqLL8AoDL3QyVn
 O29L1YAeyoRgtSFZ7c77ZDibjrDyz5b5WD0qSYyl1q8q0XgGkJ7+vrDnKIX0n2Kw/aKY
 84+pvaQyrROQqpcPxf7H1yOEzLW7wlIzNPwglJOjc3BHnWRTQLl8MOP+AQPaBpr2nf2e
 H1nw==
X-Gm-Message-State: AOJu0YyqVcOycZ6RLUH8D2YlQWhuPBSe0bL8LGJevufJxIRRO+Lmff4i
 Fy1upHhK4J3wVTwPMpB82YzGOqgKMlVcKAZRVwEN6Wk9ufnZ9RhYN+zDCA==
X-Gm-Gg: ASbGncvKzRZGM7TvMlHd5mMx9lsGi1IoW4buwr5hu34KTwd/Zb6aAUYLozeiLjg8yO+
 hA2CzXnFCwBYfTlN8owrJZWaBV6ljxuWs8YqImKcrN291rvaZAg7pM5dPVzgSR6adIq99ArByl7
 KQz8x5OLVQDTg6xDLaJTGmmehzfRh5gFgz5TSl7STGzwkOhWY8vdUPDVRIr3XKwnOqIA19b7Uke
 1P0Or40NcAVvdu/CAe4wQj8jZvrsqi6ied7oAy9Qh3oHh5p019Q+QlqTQTO7+h1WMyfYfCV6AzB
 ryfTvMSEKwatJ3kjE6zowehVKoe4fm5qhg6yzenU2AG4NceEkQBA74MW5Sk=
X-Google-Smtp-Source: AGHT+IFKN/Uag9L4TMhsbFMJwsjVvE37yD4Poyvd9H7yaA4lQr0HiQk9uIGpxAlxGoWRLENYbl+Z2A==
X-Received: by 2002:a17:902:dac9:b0:224:194c:6942 with SMTP id
 d9443c01a7336-22dbf63d31cmr107577265ad.34.1745718115988; 
 Sat, 26 Apr 2025 18:41:55 -0700 (PDT)
Received: from localhost.localdomain ([2800:2121:b000:82e:40de:33bb:8529:da8d])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-22db4dbcc1bsm56250415ad.74.2025.04.26.18.41.54
 for <ffmpeg-devel@ffmpeg.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 26 Apr 2025 18:41:55 -0700 (PDT)
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Date: Sat, 26 Apr 2025 22:41:41 -0300
Message-ID: <20250427014141.1211-1-jamrial@gmail.com>
X-Mailer: git-send-email 2.49.0
In-Reply-To: <20250426234122.4953-1-jamrial@gmail.com>
References: <20250426234122.4953-1-jamrial@gmail.com>
MIME-Version: 1.0
Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/decode: sync side_data_pref_mask
 across worker threads
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250427014141.1211-1-jamrial@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

side_data_pref_mask is set during ff_decode_preinit() and then never copied to
worker threads. As such, any decoder calling one of the side data helpers that
rely on side_data_pref() in frame threaded scenarios will ignore the user set
list of side data types.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/decode.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index c2b2dd6e3b..20e99b3ffb 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@ -2209,6 +2209,7 @@ void ff_decode_internal_sync(AVCodecContext *dst, const AVCodecContext *src)
     const DecodeContext *src_dc = decode_ctx(src->internal);
     DecodeContext *dst_dc = decode_ctx(dst->internal);
 
+    dst_dc->side_data_pref_mask = src_dc->side_data_pref_mask;
     av_refstruct_replace(&dst_dc->lcevc, src_dc->lcevc);
 }
 
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".