From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/decode: sync side_data_pref_mask across worker threads Date: Sat, 26 Apr 2025 22:41:41 -0300 Message-ID: <20250427014141.1211-1-jamrial@gmail.com> (raw) In-Reply-To: <20250426234122.4953-1-jamrial@gmail.com> side_data_pref_mask is set during ff_decode_preinit() and then never copied to worker threads. As such, any decoder calling one of the side data helpers that rely on side_data_pref() in frame threaded scenarios will ignore the user set list of side data types. Signed-off-by: James Almer <jamrial@gmail.com> --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index c2b2dd6e3b..20e99b3ffb 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -2209,6 +2209,7 @@ void ff_decode_internal_sync(AVCodecContext *dst, const AVCodecContext *src) const DecodeContext *src_dc = decode_ctx(src->internal); DecodeContext *dst_dc = decode_ctx(dst->internal); + dst_dc->side_data_pref_mask = src_dc->side_data_pref_mask; av_refstruct_replace(&dst_dc->lcevc, src_dc->lcevc); } -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-04-27 1:42 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-04-26 23:41 [FFmpeg-devel] [PATCH] avcodec/pthread_frame: sync decoded_side_data arrays with all " James Almer 2025-04-27 1:41 ` James Almer [this message] 2025-04-27 18:52 ` [FFmpeg-devel] [PATCH 2/2] avcodec/decode: sync side_data_pref_mask across " Andreas Rheinhardt 2025-04-27 19:19 ` James Almer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250427014141.1211-1-jamrial@gmail.com \ --to=jamrial@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git