From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avcodec/pthread_frame: sync decoded_side_data arrays with all worker threads Date: Sat, 26 Apr 2025 20:41:22 -0300 Message-ID: <20250426234122.4953-1-jamrial@gmail.com> (raw) After being filled by FFCodec->init() from the first worker thread, it needs to be copied to every other thread context. Otherwise, its entries will not be present when ff_decode_frame_props() populates output frames. Signed-off-by: James Almer <jamrial@gmail.com> --- libavcodec/pthread_frame.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 4ea5dd3698..7019108af6 100644 --- a/libavcodec/pthread_frame.c +++ b/libavcodec/pthread_frame.c @@ -905,6 +905,14 @@ static av_cold int init_thread(PerThreadContext *p, int *threads_to_free, if (err < 0) return err; } + } else { + for (int i = 0; i < avctx->nb_decoded_side_data; i++) { + err = av_frame_side_data_clone(©->decoded_side_data, + ©->nb_decoded_side_data, + avctx->decoded_side_data[i], 0); + if (err < 0) + return err; + } } atomic_init(&p->debug_threads, (copy->debug & FF_DEBUG_THREADS) != 0); -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2025-04-26 23:41 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-04-26 23:41 James Almer [this message] 2025-04-27 1:41 ` [FFmpeg-devel] [PATCH 2/2] avcodec/decode: sync side_data_pref_mask across " James Almer 2025-04-27 18:52 ` Andreas Rheinhardt 2025-04-27 19:19 ` James Almer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250426234122.4953-1-jamrial@gmail.com \ --to=jamrial@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git