Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] ogg/{vorbis, flac, opus}: Remove header packets from subsequent ogg streams from the demuxer output.
Date: Sat, 26 Apr 2025 03:38:11 +0200
Message-ID: <20250426013811.GB4991@pb2> (raw)
In-Reply-To: <20250422214408.10102-3-romain.beauxis@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2336 bytes --]

On Tue, Apr 22, 2025 at 04:44:08PM -0500, Romain Beauxis wrote:
> ---
>  libavformat/oggdec.c                       | 26 ++++++++++----------
>  libavformat/oggdec.h                       |  6 +++++
>  libavformat/oggparseflac.c                 | 28 ++++++++++++++++++++--
>  libavformat/oggparseopus.c                 | 12 ++++++++++
>  libavformat/oggparsevorbis.c               |  4 +++-
>  tests/ref/fate/ogg-flac-chained-meta.txt   |  2 --
>  tests/ref/fate/ogg-opus-chained-meta.txt   |  1 -
>  tests/ref/fate/ogg-vorbis-chained-meta.txt |  3 ---
>  8 files changed, 61 insertions(+), 21 deletions(-)

Is this supposed to pass fate ?

make: *** [tests/Makefile:316: fate-vorbis-3] Error 1
make: *** [tests/Makefile:316: fate-vorbis-2] Error 1
make: *** [tests/Makefile:316: fate-vorbis-1] Error 1
make: *** [tests/Makefile:315: fate-vorbis-5] Error 1
make: *** [tests/Makefile:316: fate-vorbis-4] Error 1
make: *** [tests/Makefile:316: fate-vorbis-10] Error 1
make: *** [tests/Makefile:316: fate-vorbis-6] Error 1
make: *** [tests/Makefile:316: fate-vorbis-9] Error 1
make: *** [tests/Makefile:316: fate-vorbis-7] Error 1
make: *** [tests/Makefile:316: fate-vorbis-8] Error 1
make: *** [tests/Makefile:316: fate-vorbis-11] Error 1
make: *** [tests/Makefile:316: fate-vorbis-13] Error 1
make: *** [tests/Makefile:315: fate-vorbis-12] Error 1
make: *** [tests/Makefile:316: fate-vorbis-15] Error 1
make: *** [tests/Makefile:315: fate-vorbis-16] Error 1
make: *** [tests/Makefile:316: fate-vorbis-17] Error 1
make: *** [tests/Makefile:316: fate-vorbis-18] Error 1
make: *** [tests/Makefile:315: fate-vorbis-14] Error 1
make: *** [tests/Makefile:316: fate-vorbis-19] Error 1
make: *** [tests/Makefile:316: fate-vorbis-20] Error 1
make: *** [tests/Makefile:316: fate-vorbis-encode] Error 1
make: *** [tests/Makefile:316: fate-lavf-fate-vp8.ogg] Error 1
make: *** [tests/Makefile:316: fate-limited_input_seek] Error 1
make: *** [tests/Makefile:316: fate-limited_input_seek-copyts] Error 1
make: *** [tests/Makefile:316: fate-webm-dash-chapters] Error 1
make: *** [tests/Makefile:316: fate-mov-mp4-chapters] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Nations do behave wisely once they have exhausted all other alternatives. 
-- Abba Eban

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-04-26  1:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 21:44 [FFmpeg-devel] [PATCH 0/2] Remove chained ogg stream header packets from demuxer Romain Beauxis
2025-04-22 21:44 ` [FFmpeg-devel] [PATCH 1/2] tests: Add stream dump test API util, use it to dump stream data for chained ogg/{vorbis, opus, flac} streams Romain Beauxis
2025-04-26  3:11   ` Michael Niedermayer
2025-04-26 10:45     ` Lynne
2025-04-26 11:52       ` Michael Niedermayer
2025-04-22 21:44 ` [FFmpeg-devel] [PATCH 2/2] ogg/{vorbis, flac, opus}: Remove header packets from subsequent ogg streams from the demuxer output Romain Beauxis
2025-04-26  1:38   ` Michael Niedermayer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250426013811.GB4991@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git