From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 65EB14DBD9
	for <ffmpegdev@gitmailbox.com>; Wed, 23 Apr 2025 19:52:52 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AEA6F6882FD;
	Wed, 23 Apr 2025 22:52:46 +0300 (EEST)
Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net
 [217.70.183.193])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CCE95687ACF
 for <ffmpeg-devel@ffmpeg.org>; Wed, 23 Apr 2025 22:52:40 +0300 (EEST)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 0D12C43A2D
 for <ffmpeg-devel@ffmpeg.org>; Wed, 23 Apr 2025 19:52:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1745437960;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=IXsSXm+/Vg5K7XHm+kE+da8R+z9/vr5H0p3yfreHR/Y=;
 b=CZS66BB38yuTD/CKoT+MRzZtSm8hqYoPve3KNuzcCVdESvP7oPcASPog11VFoSPnZRTC4V
 TbciCYlU/LqtWQEe3bZl2s+WzY6okX8F5cF6vtkMDyNX6XuQZbx2fXeTdQR66ia/HfaftM
 tRw63b/ktMpWEAWXeyxRH3rUzV17LXI+MZzlOrKlfLmrHpCI1hJDUEATv/Gv6xWVBp+oPH
 PmThQnrkzhljlBhVc89KR3e4TuWYjCe/krNkM3oImIflxi9Wq2T9ZOQBZGafUH+vx5X4q4
 IUfmefuW/LqMVJcNbD5Om/HhEsEqygnwd53q+/ai5ok7IjNXTcXXJuffEqXTNg==
Date: Wed, 23 Apr 2025 21:52:38 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20250423195238.GR4991@pb2>
References: <20250421152445.2110045-1-sw@jkqxz.net>
 <20250421152445.2110045-6-sw@jkqxz.net>
MIME-Version: 1.0
In-Reply-To: <20250421152445.2110045-6-sw@jkqxz.net>
X-GND-State: clean
X-GND-Score: -70
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeejgeelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH v2 5/6] lavc/apv: AVX2 transquant for
 x86-64
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============3001294864686869673=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250423195238.GR4991@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============3001294864686869673==
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="e6gUhF6583PHp48G"
Content-Disposition: inline


--e6gUhF6583PHp48G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi

On Mon, Apr 21, 2025 at 04:24:36PM +0100, Mark Thompson wrote:
> Typical checkasm result on Alder Lake:
>=20
> decode_transquant_8_c:                                 461.1 ( 1.00x)
> decode_transquant_8_avx2:                               97.5 ( 4.73x)
> decode_transquant_10_c:                                483.9 ( 1.00x)
> decode_transquant_10_avx2:                              91.7 ( 5.28x)
> ---
>  libavcodec/apv_dsp.c          |   4 +
>  libavcodec/apv_dsp.h          |   2 +
>  libavcodec/x86/Makefile       |   2 +
>  libavcodec/x86/apv_dsp.asm    | 279 ++++++++++++++++++++++++++++++++++
>  libavcodec/x86/apv_dsp_init.c |  40 +++++
>  tests/checkasm/Makefile       |   1 +
>  tests/checkasm/apv_dsp.c      | 109 +++++++++++++
>  tests/checkasm/checkasm.c     |   3 +
>  tests/checkasm/checkasm.h     |   1 +
>  tests/fate/checkasm.mak       |   1 +
>  10 files changed, 442 insertions(+)
>  create mode 100644 libavcodec/x86/apv_dsp.asm
>  create mode 100644 libavcodec/x86/apv_dsp_init.c
>  create mode 100644 tests/checkasm/apv_dsp.c

breaks build on x86-32
make
X86ASM	libavcodec/x86/apv_dsp.o
src/libavcodec/x86/apv_dsp.asm:64: error: symbol `m10' undefined
src/libavcodec/x86/apv_dsp.asm:66: error: symbol `xmmm8' undefined
src//libavutil/x86/x86inc.asm:1637: ... from macro `movd' defined here
src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined =
here
src/libavcodec/x86/apv_dsp.asm:67: error: symbol `xmmm9' undefined
src//libavutil/x86/x86inc.asm:1637: ... from macro `movd' defined here
src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined =
here
src/libavcodec/x86/apv_dsp.asm:68: error: symbol `m10' undefined
src/libavcodec/x86/apv_dsp.asm:69: error: symbol `m10' undefined
src/libavcodec/x86/apv_dsp.asm:86: error: symbol `m11' undefined
src/libavcodec/x86/apv_dsp.asm:78: ... from macro `LOAD_AND_DEQUANT' define=
d here
src/libavcodec/x86/apv_dsp.asm:86: error: symbol `m11' undefined
src/libavcodec/x86/apv_dsp.asm:79: ... from macro `LOAD_AND_DEQUANT' define=
d here
src/libavcodec/x86/apv_dsp.asm:86: error: symbol `xmmm8' undefined
src/libavcodec/x86/apv_dsp.asm:80: ... from macro `LOAD_AND_DEQUANT' define=
d here
src/libavcodec/x86/apv_dsp.asm:86: error: symbol `m10' undefined
src/libavcodec/x86/apv_dsp.asm:81: ... from macro `LOAD_AND_DEQUANT' define=
d here
src/libavcodec/x86/apv_dsp.asm:86: error: symbol `xmmm9' undefined
src/libavcodec/x86/apv_dsp.asm:82: ... from macro `LOAD_AND_DEQUANT' define=
d here
src/libavcodec/x86/apv_dsp.asm:87: error: symbol `m11' undefined
src/libavcodec/x86/apv_dsp.asm:78: ... from macro `LOAD_AND_DEQUANT' define=
d here
=2E..

thx

[...]
--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein

--e6gUhF6583PHp48G
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaAlFAwAKCRBhHseHBAsP
q5UYAJ9V5hzmITZtV6keNcB9Lk/hEQLX7ACgk/Ne5nEgVf9FNX+a9NFJe9IGctk=
=pmiT
-----END PGP SIGNATURE-----

--e6gUhF6583PHp48G--

--===============3001294864686869673==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============3001294864686869673==--