From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id E5B444DA4A
for <ffmpegdev@gitmailbox.com>; Mon, 21 Apr 2025 21:30:45 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA504689ABD;
Tue, 22 Apr 2025 00:30:41 +0300 (EEST)
Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net
[217.70.183.197])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 81545687D80
for <ffmpeg-devel@ffmpeg.org>; Tue, 22 Apr 2025 00:30:34 +0300 (EEST)
Received: by mail.gandi.net (Postfix) with ESMTPSA id B0F7643A7B
for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 21:30:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
s=gm1; t=1745271033;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=YPEpp4cOquG7rZV6fek9sYTaT83VM5Q6dmLDWokqcCI=;
b=SIYyfKcim9UbOM4r1k9TDlcOdllHtgi9WdKTfJK19oJVosIjuh/r634zfeeLPDJqEKtuS2
6xZvNx84lKmIS7tJVnvnbuDd539s8L7RPXAT/z6qe+FR+8w600tSaL64+SXmCwfBQhjLaZ
rM8l/zETV+taGqdhoExX/HjztCt2JtvfkAWSP2oVfLOXgEVPp99CDnC1kDwJmOtW1It9kB
XoVfr3piCUWZGE3FjB+rqDsOSOv1W/cRtaYlgl0CdaNb0V5jOpoB37Vj58gNmhLohPrVym
Y1corG+3dg0hnvFAa4zryI8L677pOgiYTG78KYMoE5OAoKz6J6cKQxYwf2O3Yg==
Date: Mon, 21 Apr 2025 23:30:32 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20250421213032.GN4991@pb2>
References: <20250419190712.1265201-1-sw@jkqxz.net>
<20250419190712.1265201-3-sw@jkqxz.net>
MIME-Version: 1.0
In-Reply-To: <20250419190712.1265201-3-sw@jkqxz.net>
X-GND-State: clean
X-GND-Score: -70
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeduleefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH 2/6] lavf: APV demuxer
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============5583278218256320040=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250421213032.GN4991@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
--===============5583278218256320040==
Content-Type: multipart/signed; micalg=pgp-sha512;
protocol="application/pgp-signature"; boundary="AdyQpTPiDYJ+o+oz"
Content-Disposition: inline
--AdyQpTPiDYJ+o+oz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Apr 19, 2025 at 08:07:00PM +0100, Mark Thompson wrote:
> Demuxes raw streams as defined in draft spec section 10.2.
> ---
> libavformat/Makefile | 1 +
> libavformat/allformats.c | 1 +
> libavformat/apvdec.c | 245 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 247 insertions(+)
> create mode 100644 libavformat/apvdec.c
[...]
> +static int apv_probe(const AVProbeData *p)
> +{
> + GetBitContext gbc;
> + APVHeaderInfo header;
> + uint32_t au_size, tag, pbu_size;
> + int score =3D AVPROBE_SCORE_EXTENSION + 1;
> + int ret;
> +
> + init_get_bits8(&gbc, p->buf, p->buf_size);
> +
> + au_size =3D get_bits_long(&gbc, 32);
> + if (au_size < 16) {
> + // Too small.
> + return 0;
> + }
> + // The spec doesn't have this tag, but the reference software and
> + // all current files do. Treat it as optional and skip if present,
> + // but if it is there then this is definitely an APV file.
> + tag =3D get_bits_long(&gbc, 32);
> + if (tag =3D=3D APV_TAG) {
> + pbu_size =3D get_bits_long(&gbc, 32);
> + score =3D AVPROBE_SCORE_MAX;
> + } else {
> + pbu_size =3D tag;
> + }
> + if (pbu_size < 16) {
> + // Too small.
> + return 0;
> + }
> +
> + ret =3D apv_extract_header_info(&header, &gbc);
> + if (ret =3D=3D 0)
> + return 0;
> + return score;
> +}
tools/probetest 256 4096
Failure of apv probing code with score=3D51 type=3D1 p=3DF14 size=3D32
(yes i saw you posted a new patch, but still had the old one locally
and saw this, so reporting anyway)
thx
[...]
--=20
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
--AdyQpTPiDYJ+o+oz
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaAa49QAKCRBhHseHBAsP
q2c9AJ9+QYYe2KZWdIMW4finw0D1LXVfGACfc/shAQ7JGwTiCY/ecqasXZzPudg=
=LEVX
-----END PGP SIGNATURE-----
--AdyQpTPiDYJ+o+oz--
--===============5583278218256320040==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--===============5583278218256320040==--