From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id F01664D35E for <ffmpegdev@gitmailbox.com>; Thu, 17 Apr 2025 00:24:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0B4D868A4C3; Thu, 17 Apr 2025 03:24:13 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9F9F1687CAC for <ffmpeg-devel@ffmpeg.org>; Thu, 17 Apr 2025 03:24:06 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id D790F439FA for <ffmpeg-devel@ffmpeg.org>; Thu, 17 Apr 2025 00:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1744849446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SHc3XD7aEFdBVNtjM6Z7eja7/epLCFaMX+dnjCdrCKs=; b=Tu6hSh+v9VRyo3/F/T7heMxSljuu/ud4jg2vb8UaECciB6scnWIsP76yhoQPe6J4xLjemC 96/Hr8BnaMGUOuEl6Er5c+bOaDYbufRCA6gm/9Z1Mv7De/ahySdgdl3cKVbTg3hZv8XXwk /0Zm5MkCh+Mx1tlFfL1b6vuisyHuaXYt06PRZdJG3Qt4A9b5544Fn4rlqDmIczcjru7wph N+/02s86roifxlMkgYXPjpFu7ysJ22Vtzb+FyQGGPjlZigoK/uaaRmLoIQCQUX4PBBQsJs X9+GVrR0inFnwIgnZvRNJf4lV3xQpbVyZQUKb1OSThbR8BiaVT7nGCbzp2nuKg== Date: Thu, 17 Apr 2025 02:24:04 +0200 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20250417002404.GS4991@pb2> References: <20250321155502.418939-1-gruttersleonbot2@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250321155502.418939-1-gruttersleonbot2@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdejkedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/webvttdec: strip classes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============2642673573105627936==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250417002404.GS4991@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============2642673573105627936== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Y4Sa+4nNfxZpowqA" Content-Disposition: inline --Y4Sa+4nNfxZpowqA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Fri, Mar 21, 2025 at 04:55:02PM +0100, Leon Grutters wrote: > If a supported tag has a class, e.g "<i.bold>" it is ignored entirely; > so for example "<i.bold>Hello</i>" would be converted to "Hello{\i0}" > instead of the intended "{\i1}Hello{\i0}". >=20 > Signed-off-by: Leon Grutters <gruttersleonbot2@gmail.com> > --- > libavcodec/webvttdec.c | 39 ++++++++++++++++++++++++++++----------- > 1 file changed, 28 insertions(+), 11 deletions(-) I see no fate tests changing. So it seems theres a lack of tests maybe you can add some tests while you wait for someone to review This would avoid future regressions thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates --Y4Sa+4nNfxZpowqA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaABKJAAKCRBhHseHBAsP qygkAJ0QliU3ysM7/ZzgesJhQheGypMsjACeMN+7inYcRLSfXhUNhNo1dkPC2kg= =V/hJ -----END PGP SIGNATURE----- --Y4Sa+4nNfxZpowqA-- --===============2642673573105627936== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2642673573105627936==--