From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dvbsubenc: Sanity check num_rects Date: Thu, 17 Apr 2025 02:14:09 +0200 Message-ID: <20250417001409.GR4991@pb2> (raw) In-Reply-To: <GV1P250MB0737BA9573ABC00B1B8FF6448FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> [-- Attachment #1.1: Type: text/plain, Size: 1638 bytes --] On Wed, Apr 16, 2025 at 11:17:30AM +0200, Andreas Rheinhardt wrote: > Patches attached. > > - Andreas > dvbsubenc.c | 3 +++ > 1 file changed, 3 insertions(+) > 27ce315dbaee02f8c92c12f8c9cd0c8c7edc54fb 0001-avcodec-dvbsubenc-Sanity-check-num_rects.patch > From b3a4381000d13ac344114dd5f0230c9eae7b32aa Mon Sep 17 00:00:00 2001 > From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > Date: Wed, 16 Apr 2025 10:23:01 +0200 > Subject: [PATCH 1/2] avcodec/dvbsubenc: Sanity check num_rects > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > It is written as region_id which is a single byte. > Also fixes a potential (defined) overflow in the num_rects * 6 > multiplication later; this has been found by 김승호 <kimsho98@naver.com>. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > libavcodec/dvbsubenc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/dvbsubenc.c b/libavcodec/dvbsubenc.c > index 822e3a5309..8eeac76855 100644 > --- a/libavcodec/dvbsubenc.c > +++ b/libavcodec/dvbsubenc.c > @@ -284,6 +284,9 @@ static int dvbsub_encode(AVCodecContext *avctx, uint8_t *outbuf, int buf_size, > if (h->num_rects && !h->rects) > return AVERROR(EINVAL); > > + if (h->num_rects >= 256) > + return AVERROR_INVALIDDATA; should this not be AVERROR(EINVAL); ? thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-04-17 0:14 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-04-16 9:17 Andreas Rheinhardt 2025-04-17 0:14 ` Michael Niedermayer [this message] 2025-04-17 12:06 ` Andreas Rheinhardt 2025-04-20 16:29 ` Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250417001409.GR4991@pb2 \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git