From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id DD4CC4D096
	for <ffmpegdev@gitmailbox.com>; Wed, 16 Apr 2025 00:34:46 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9578A687DC6;
	Wed, 16 Apr 2025 03:34:43 +0300 (EEST)
Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net
 [217.70.183.194])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 14887687D0C
 for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 03:34:37 +0300 (EEST)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 6BD7843844
 for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 00:34:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1744763676;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=AW7yAqkfAmzDMFvf1LEK+YFt3eL7erdaEiVC0iDLUDk=;
 b=nK2Myg5sJhStGi6fhH+f5j9jS5zCfaOQrjNN4XXstW1Fd79UoZbbMkyUjsOXr/mCOi8hg6
 E7XfIR6/bRkqE7AIFDt1KMbzrVVoVVfDgvI6XAloAkRWo6m+eWcjyFYPV/1fZbvH5NEjle
 0yRlmNEJ4SiMNJZ8Vq4zUkRKjPmmdKAiD3zco0hTL6RJ7APCqHDS2IRjVJqWrxb0WYHBlN
 96rhpz26R2cOgKxFP0dbskKVKthA/wG8RV2nUy4afUlYd8oNWRWZWnNJ09a/X3FU/98r+/
 BXAmab3SnFwTkku9FKf48fJyEyPNW2bIN7jU6AxdoL1m8WtRcZ82Ti7BPbil8g==
Date: Wed, 16 Apr 2025 02:34:35 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20250416003435.GC4991@pb2>
References: <20250410170504.308400-1-michael@niedermayer.cc>
 <GV1P250MB073772D581844374C47913578FB62@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
 <20250412001132.GF4991@pb2>
 <16bef658-ba7c-48ff-b7fd-f9d449488f49@rothenpieler.org>
 <20250412004211.GH4991@pb2>
MIME-Version: 1.0
In-Reply-To: <20250412004211.GH4991@pb2>
X-GND-State: clean
X-GND-Score: -70
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdegleegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH v2] configure: Clearer documentation for
 "disable-safe-bitstream-reader"
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============0201794526637849712=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250416003435.GC4991@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============0201794526637849712==
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="P/xdpHgqfLoQ2QmY"
Content-Disposition: inline


--P/xdpHgqfLoQ2QmY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 12, 2025 at 02:42:11AM +0200, Michael Niedermayer wrote:
> On Sat, Apr 12, 2025 at 02:19:08AM +0200, Timo Rothenpieler wrote:
> > On 12.04.2025 02:11, Michael Niedermayer wrote:
> > > On Fri, Apr 11, 2025 at 08:32:55AM +0200, Andreas Rheinhardt wrote:
> > > > Michael Niedermayer:
> > > > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > > > ---
> > > > >   configure | 3 ++-
> > > > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > > >=20
> > > > > diff --git a/configure b/configure
> > > > > index bd4f8723760..f1db8b6f235 100755
> > > > > --- a/configure
> > > > > +++ b/configure
> > > > > @@ -436,7 +436,8 @@ Advanced options (experts only):
> > > > >     --enable-hardcoded-tables use hardcoded tables instead of run=
time generation
> > > > >     --disable-safe-bitstream-reader
> > > > >                              disable buffer boundary checking in =
bitreaders
> > > > > -                           (faster, but may crash)
> > > > > +                           (This disables some security checks a=
nd can cause undefined behavior,
> > > > > +                            it may be faster, but should only be=
 used with trusted input)
> > > > >     --sws-max-filter-size=3DN  the max filter size swscale uses [=
$sws_max_filter_size_default]
> > > > >   Optimization options (experts only):
> > > >=20
> > > > I'd like to keep "crash" in the description. Not everyone (not even
> > > > people setting "experts only" options) will be familiar with the te=
rm
> > > > "undefined behavior".
> > >=20
> > > what about:
> > >=20
> > > (This disables some security checks and can cause undefined behavior =
and
> > >   crashes, it may be faster, but should only be used with trusted inp=
ut)
> >=20
> > Given that the undefined behaviour can in theory even include arbitrary=
 code
> > execution, I'd probably make it even harsher and mention that worst-case
> > being a possibility.
>=20
> what about this:
>=20
> (This disables some security checks and can cause undefined behavior,
>  crashes and arbitrary code execution, it may be faster, but
>  should only be used with trusted input)

will apply, feel free to change if someone has ideas for improvment

thx

[...]

--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.

--P/xdpHgqfLoQ2QmY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ/77GwAKCRBhHseHBAsP
q0KDAJ0YMObBR2g7pcmvAS6kcDoMdTphxgCfSihvAOJMuWAIoHSDqNI3b75YBvw=
=5zxo
-----END PGP SIGNATURE-----

--P/xdpHgqfLoQ2QmY--

--===============0201794526637849712==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============0201794526637849712==--