From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E31354D073 for <ffmpegdev@gitmailbox.com>; Tue, 15 Apr 2025 23:43:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3387F687DBB; Wed, 16 Apr 2025 02:43:37 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 44305687CF9 for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 02:43:30 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9AFEA43190 for <ffmpeg-devel@ffmpeg.org>; Tue, 15 Apr 2025 23:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1744760609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lnnM3a67USYjZdPyLx06g8MBOR8XrH4bCqvWtfCBsLw=; b=f7BX2+sBUf/iI52xoV62YDnhwQH8UDmXsoIcmba+qaztxH0XGp38FJNXB4P8hZeyZ4Dlyw THwHHQz+Q0MBB/OuXpoGtN4pZijSdFVbcM2J5au0kYitIeR4jtEvHgKrHF9nWWsBHX1bU6 QdxG7GOr+aKGInOVp6CdmJ60VCPeoD3qBOpJg7B4MyE4hG2Nfyc4jf3M4Xru5XxtSuZXRM bYMBgxoc52rVgVHB8CKTdvf1lKmRf2UeKmNWZYROwv1EHx5wrJbKZzxhOVBx0Xjn8fEgh/ imRQqTU55Wf1xwJKa5nFNTfPD4HfSzIruG6Amhbtgw00RJA2bmPFHfRSBvgzkA== Date: Wed, 16 Apr 2025 01:43:28 +0200 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20250415234328.GZ4991@pb2> References: <20250410-video-only-kf-recover-v3-1-545c30c2d9f0@riseup.net> MIME-Version: 1.0 In-Reply-To: <20250410-video-only-kf-recover-v3-1-545c30c2d9f0@riseup.net> X-GND-State: clean X-GND-Score: -90 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdegkeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculddutddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeffledtfeevfeffheeuuefhtdejieelueeftdeitdfgheetgefffeefteekffdthfenucffohhmrghinhepfhhfmhhpvghgrdhorhhgnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v3] avformat/fifo: Check for keyframe video type before stop dropping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============8314571657427489417==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250415234328.GZ4991@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============8314571657427489417== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pKndAuCAu8XGkrDv" Content-Disposition: inline --pKndAuCAu8XGkrDv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 10, 2025 at 07:59:15PM -0300, Arthur Grillo wrote: > The current behavior when using restart_with_keyframe is that it will > recover if it also encounters any audio packet, as they are flagged as a > keyframe. >=20 > The expectation is that packets are dropped until the next _video_ > keyframe. >=20 > To fix that, check if exists a video stream, if it exists check the > packet stream codec type, only letting it recover when it is a video > one. If there is no video stream, resume to the original behavior, not > checking the codec type. >=20 > Fixes ticket: #11467 >=20 > Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > --- > Changes in v3: > - Terminate `has_video_stream` description comment with a space > - Fix indentation (Michael Niedermayer) > - Link to v2: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250405-= video-only-kf-recover-v2-1-000e71a29ccb@riseup.net >=20 > Changes in v2: > - Check for the presence of a video stream (Michael Niedermayer) > - Link to v1: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250312-= video-only-kf-recover-v1-1-1e0e340da663@riseup.net > --- > libavformat/fifo.c | 28 +++++++++++++++++++++++++--- > 1 file changed, 25 insertions(+), 3 deletions(-) will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Modern terrorism, a quick summary: Need oil, start war with country that has oil, kill hundread thousand in war. Let country fall into chaos, be surprised about raise of fundamantalists. Drop more bombs, kill more people, be surprised about them taking revenge and drop even more bombs and strip your own citizens of their rights and freedoms. to be continued --pKndAuCAu8XGkrDv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ/7vIAAKCRBhHseHBAsP q+EKAKCKWQ+g6pZbBTVX8ao2Pe0tdWbgjQCfQv1xg+JJqJuKGc2jZthhKp82mTU= =DH8S -----END PGP SIGNATURE----- --pKndAuCAu8XGkrDv-- --===============8314571657427489417== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8314571657427489417==--