From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1EA0B4CF4D for <ffmpegdev@gitmailbox.com>; Tue, 15 Apr 2025 18:25:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CCECF687CFB; Tue, 15 Apr 2025 21:25:46 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 61F51687C71 for <ffmpeg-devel@ffmpeg.org>; Tue, 15 Apr 2025 21:25:40 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 99DBA432FF for <ffmpeg-devel@ffmpeg.org>; Tue, 15 Apr 2025 18:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1744741539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WZlOX2B17gxTetw2EwB3L+4H5NuhFNHnmeJO2MWH/Ow=; b=HmaLvEAuQFfrON83D5O2BWr48/L4CWDYYRzUPrYjHM2kk9tpiwslJXBms4rE7YKBRq57Ht 1ysipazvrSkOL12FuUGGJpnYcwweHMb9NEDSWZ6kml2hSKdXWhYqakhIs3kYH9dhK/V3gK V/VBph0KPjvIGsv099Rjn0TwAgm5TO6KYK0iKkh++aFowiIvEWrX/J3AzB9Q2B7CYVbM+3 ewCyYVTIImEyW4FtdniHsoFBFl/lfJJstq7oGM6ZJOYW7kuB47xVrR2m438OA7OA8hr4iU lFIY75RX617nRn7bl5UwUD7oR/vbeaxtIEZYYi7txn4Mtlha7xudZ75anADyqw== Date: Tue, 15 Apr 2025 20:25:38 +0200 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20250415182538.GP4991@pb2> References: <20250411222719.2779176-1-michael@niedermayer.cc> <20250411222719.2779176-2-michael@niedermayer.cc> <DM8P223MB0365A90C10FBC9EF6512F9E1BAB12@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250414231950.GN4991@pb2> <DM8P223MB03650AB4340A4553BAA76A1CBAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> MIME-Version: 1.0 In-Reply-To: <DM8P223MB03650AB4340A4553BAA76A1CBAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdegvddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============2890463323852292202==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250415182538.GP4991@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============2890463323852292202== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QMGKjxMCyZU6Oxve" Content-Disposition: inline --QMGKjxMCyZU6Oxve Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Tue, Apr 15, 2025 at 01:37:56AM +0000, softworkz . wrote: [...] > > > do you have a test file perhaps? > >=20 > > Will email you one, but the loop with a function that doesnt advance > > is an issue even if the specific file doesnt trigger it in a different > > implementation >=20 >=20 > Thanks a lot for the test file. I was able to reproduce the eternal loop > that you were intending to fix, but I noticed that after removing the=20 > patches from rcombs, that endless loop doesn't happen in the first place. the patch was intended to fix that regression yes. But your patch contains a very similarly looking loop to what caused that. Which is what i meant, that because it looks similar it should be checked for that thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong. --QMGKjxMCyZU6Oxve Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ/6kmwAKCRBhHseHBAsP qwGrAJ9kvxeCGI19qoIsLLjp8reTCczQ7ACfbqmo7pP24qn7DEypI5EYRWLKdFM= =H6MY -----END PGP SIGNATURE----- --QMGKjxMCyZU6Oxve-- --===============2890463323852292202== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2890463323852292202==--