From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6D80B4C9F9 for <ffmpegdev@gitmailbox.com>; Fri, 11 Apr 2025 19:06:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 62B7968C3F2; Fri, 11 Apr 2025 22:06:16 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1BA11687CE8 for <ffmpeg-devel@ffmpeg.org>; Fri, 11 Apr 2025 22:06:10 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 50BB1439FA for <ffmpeg-devel@ffmpeg.org>; Fri, 11 Apr 2025 19:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1744398369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8FtAunrtyHZJTglwWmLlzYaP7qedRFKXjUcInlAr//k=; b=ToG+oFMPa5CC2K/j3E142KxI1UXQobzHH/aQXB/GyF83x522pdo4wmrYj+W7wyMjl9r15u VKacpwoVXeu6k8oJqe3MoJaR5TY1cnabOpxSNA1zwmDXnqJZmBcBQ0pdTHWCS0AqDVx1T7 wbwIUnThVYhbDLAClTqj2vh85tpXZeAOXqa0KID4tjNxfM6/TpABkeRHdqkxNmztyoTjdF lFLlEs3f+1hL0pLhIiCr8+1gVeqEba6s3kJe+1Z9nHyRBE6oAHQuIqlu4t3fGQfF91R80h oz56i45oVrGggAVFM0JOxTsakctAip19utP95sKzWRF8RZ3g756o4gawK2dJqQ== Date: Fri, 11 Apr 2025 21:06:08 +0200 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20250411190608.GC4991@pb2> References: <20250408101959.GP4991@pb2> <DM8P223MB03654302FB66A2EEB0039C45BAB52@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250408181621.GQ4991@pb2> <DM8P223MB0365F368CEF792DBBD091ABABAB52@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250408194502.GR4991@pb2> <DM8P223MB036537514113E407B2437CF3BAB52@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> MIME-Version: 1.0 In-Reply-To: <DM8P223MB036537514113E407B2437CF3BAB52@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvuddviedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeelkeeggfffiedufeejueffjeduhedttdduledtheevveevtdeiueelhfdtuedtkeenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [RFC] AVDictionary2 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============6685512599822298936==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250411190608.GC4991@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============6685512599822298936== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V3TzC7E8Jed9/t8t" Content-Disposition: inline --V3TzC7E8Jed9/t8t Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Tue, Apr 08, 2025 at 09:30:16PM +0000, softworkz . wrote: [...] > To tell you the truth - at that point I was thinking: "Ah, clever! That's= why the AVDictionary is done like that" =F0=9F=98=8A=20 The dictionary implementation is not clever look at copy for example it iterates over av_dict_set() which itself calls av_dict_get() which it itself iterates over the dictionary so av_dict_copy() is O(n^2) for example also a single fate run, calls av_dict_iterate() 4921207 times and fate should mostly be short small files and minimal self contained test= cases thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failure, be that a person or equipment. --V3TzC7E8Jed9/t8t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ/loHAAKCRBhHseHBAsP q3QgAJ9X1/9pGYRYE0QhmPyERRPFpDZWTgCfUcKU+vtLh+GsKrj3yen7d23YuWE= =ubYz -----END PGP SIGNATURE----- --V3TzC7E8Jed9/t8t-- --===============6685512599822298936== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6685512599822298936==--