From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC] AVDictionary2
Date: Fri, 11 Apr 2025 21:06:08 +0200
Message-ID: <20250411190608.GC4991@pb2> (raw)
In-Reply-To: <DM8P223MB036537514113E407B2437CF3BAB52@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
[-- Attachment #1.1: Type: text/plain, Size: 732 bytes --]
Hi
On Tue, Apr 08, 2025 at 09:30:16PM +0000, softworkz . wrote:
[...]
> To tell you the truth - at that point I was thinking: "Ah, clever! That's why the AVDictionary is done like that" 😊
The dictionary implementation is not clever
look at copy for example it iterates over av_dict_set() which itself calls
av_dict_get() which it itself iterates over the dictionary
so av_dict_copy() is O(n^2) for example
also a single fate run, calls av_dict_iterate() 4921207 times
and fate should mostly be short small files and minimal self contained testcases
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Avoid a single point of failure, be that a person or equipment.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-04-11 19:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 10:19 Michael Niedermayer
2025-04-08 16:10 ` Romain Beauxis
2025-04-08 20:29 ` Michael Niedermayer
2025-04-08 22:18 ` Gerion Entrup
2025-04-08 22:35 ` Michael Niedermayer
2025-04-08 22:37 ` softworkz .
2025-04-08 16:56 ` softworkz .
2025-04-08 18:16 ` Michael Niedermayer
2025-04-08 18:36 ` softworkz .
2025-04-08 19:45 ` Michael Niedermayer
2025-04-08 21:30 ` softworkz .
2025-04-11 19:06 ` Michael Niedermayer [this message]
2025-04-12 1:41 ` softworkz .
2025-04-12 11:02 ` softworkz .
2025-04-09 0:00 ` Leo Izen
2025-04-09 16:56 ` Michael Niedermayer
2025-04-10 8:40 ` Nicolas George
2025-04-10 18:31 ` softworkz .
2025-04-11 20:50 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411190608.GC4991@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git