[FFmpeg-devel] [PATCH] libpostproc: remove AMD 3DNow! define

[FFmpeg-devel] [PATCH] libpostproc: remove AMD 3DNow! define

[Sean McGovern]

It was removed / left unreferenced some time ago.
---
 libpostproc/postprocess.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
index 5decb7e8a9..cc48c552cc 100644
--- a/libpostproc/postprocess.h
+++ b/libpostproc/postprocess.h
@@ -87,7 +87,6 @@ void pp_free_context(pp_context *ppContext);
 
 #define PP_CPU_CAPS_MMX   0x80000000
 #define PP_CPU_CAPS_MMX2  0x20000000
-#define PP_CPU_CAPS_3DNOW 0x40000000
 #define PP_CPU_CAPS_ALTIVEC 0x10000000
 #define PP_CPU_CAPS_AUTO  0x00080000
 
-- 
2.39.5

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libpostproc: remove AMD 3DNow! define

[Andreas Rheinhardt]

Sean McGovern:
> It was removed / left unreferenced some time ago.
> ---
>  libpostproc/postprocess.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
> index 5decb7e8a9..cc48c552cc 100644
> --- a/libpostproc/postprocess.h
> +++ b/libpostproc/postprocess.h
> @@ -87,7 +87,6 @@ void pp_free_context(pp_context *ppContext);
>  
>  #define PP_CPU_CAPS_MMX   0x80000000
>  #define PP_CPU_CAPS_MMX2  0x20000000
> -#define PP_CPU_CAPS_3DNOW 0x40000000
>  #define PP_CPU_CAPS_ALTIVEC 0x10000000
>  #define PP_CPU_CAPS_AUTO  0x00080000
>  

Missing deprecation etc. As has been said.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libpostproc: remove AMD 3DNow! define

[Sean McGovern]

On Fri, Apr 11, 2025 at 9:17 AM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Sean McGovern:
> > It was removed / left unreferenced some time ago.
> > ---
> >  libpostproc/postprocess.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
> > index 5decb7e8a9..cc48c552cc 100644
> > --- a/libpostproc/postprocess.h
> > +++ b/libpostproc/postprocess.h
> > @@ -87,7 +87,6 @@ void pp_free_context(pp_context *ppContext);
> >
> >  #define PP_CPU_CAPS_MMX   0x80000000
> >  #define PP_CPU_CAPS_MMX2  0x20000000
> > -#define PP_CPU_CAPS_3DNOW 0x40000000
> >  #define PP_CPU_CAPS_ALTIVEC 0x10000000
> >  #define PP_CPU_CAPS_AUTO  0x00080000
> >
>
> Missing deprecation etc. As has been said.

WHY does this need a deprecation period? It neither enables nor
disables anything.

>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

-- Sean McGovern
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libpostproc: remove AMD 3DNow! define

[Nicolas George]

Sean McGovern (HE12025-04-11):
> WHY does this need a deprecation period? It neither enables nor
> disables anything.

If somebody uses it in their code, the fact that it does nothing will
not prevent the compilation to fail.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libpostproc: remove AMD 3DNow! define

[Andreas Rheinhardt]

Sean McGovern:
> On Fri, Apr 11, 2025 at 9:17 AM Andreas Rheinhardt
> <andreas.rheinhardt@outlook.com> wrote:
>>
>> Sean McGovern:
>>> It was removed / left unreferenced some time ago.
>>> ---
>>>  libpostproc/postprocess.h | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
>>> index 5decb7e8a9..cc48c552cc 100644
>>> --- a/libpostproc/postprocess.h
>>> +++ b/libpostproc/postprocess.h
>>> @@ -87,7 +87,6 @@ void pp_free_context(pp_context *ppContext);
>>>
>>>  #define PP_CPU_CAPS_MMX   0x80000000
>>>  #define PP_CPU_CAPS_MMX2  0x20000000
>>> -#define PP_CPU_CAPS_3DNOW 0x40000000
>>>  #define PP_CPU_CAPS_ALTIVEC 0x10000000
>>>  #define PP_CPU_CAPS_AUTO  0x00080000
>>>
>>
>> Missing deprecation etc. As has been said.
> 
> WHY does this need a deprecation period? It neither enables nor
> disables anything.
> 

Because it is public API. Users may set still set it (although it does
nothing).

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] libpostproc: deprecate the AMD 3DNow! define

[Sean McGovern]

It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f.
---
 libpostproc/postprocess.h | 2 ++
 libpostproc/version.h     | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
index 5decb7e8a9..7010c2b51b 100644
--- a/libpostproc/postprocess.h
+++ b/libpostproc/postprocess.h
@@ -87,7 +87,9 @@ void pp_free_context(pp_context *ppContext);
 
 #define PP_CPU_CAPS_MMX   0x80000000
 #define PP_CPU_CAPS_MMX2  0x20000000
+#if PP_AMD_3DNOW
 #define PP_CPU_CAPS_3DNOW 0x40000000
+#endif
 #define PP_CPU_CAPS_ALTIVEC 0x10000000
 #define PP_CPU_CAPS_AUTO  0x00080000
 
diff --git a/libpostproc/version.h b/libpostproc/version.h
index bcbdd210c4..5a272630bf 100644
--- a/libpostproc/version.h
+++ b/libpostproc/version.h
@@ -43,4 +43,6 @@
 
 #define LIBPOSTPROC_IDENT       "postproc" AV_STRINGIFY(LIBPOSTPROC_VERSION)
 
+#define PP_AMD_3DNOW               (LIBPOSTPROC_VERSION_MAJOR < 60)
+
 #endif /* POSTPROC_VERSION_H */
-- 
2.39.5

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] libpostproc: deprecate the AMD 3DNow! define

[Sean McGovern]

Hi,


On Fri, Apr 11, 2025, 09:52 Sean McGovern <gseanmcg@gmail.com> wrote:

> It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f.
> ---
>  libpostproc/postprocess.h | 2 ++
>  libpostproc/version.h     | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
> index 5decb7e8a9..7010c2b51b 100644
> --- a/libpostproc/postprocess.h
> +++ b/libpostproc/postprocess.h
> @@ -87,7 +87,9 @@ void pp_free_context(pp_context *ppContext);
>
>  #define PP_CPU_CAPS_MMX   0x80000000
>  #define PP_CPU_CAPS_MMX2  0x20000000
> +#if PP_AMD_3DNOW
>  #define PP_CPU_CAPS_3DNOW 0x40000000
> +#endif
>  #define PP_CPU_CAPS_ALTIVEC 0x10000000
>  #define PP_CPU_CAPS_AUTO  0x00080000
>
> diff --git a/libpostproc/version.h b/libpostproc/version.h
> index bcbdd210c4..5a272630bf 100644
> --- a/libpostproc/version.h
> +++ b/libpostproc/version.h
> @@ -43,4 +43,6 @@
>
>  #define LIBPOSTPROC_IDENT       "postproc"
> AV_STRINGIFY(LIBPOSTPROC_VERSION)
>
> +#define PP_AMD_3DNOW               (LIBPOSTPROC_VERSION_MAJOR < 60)
> +
>  #endif /* POSTPROC_VERSION_H */
> --
> 2.39.5
>

Did I do this correctly this time?

Also it seems a bit much to wait a year or more for this to be actually
removed. Can it instead be keyed to the next minor bump, or is this against
some guarantee we give our downstreams?

-- Sean McGovern

>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v3] libpostproc: deprecate the AMD 3DNow! define

[Sean McGovern]

It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f.
---
 libpostproc/postprocess.h   | 2 ++
 libpostproc/version_major.h | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
index 5decb7e8a9..e210e93b11 100644
--- a/libpostproc/postprocess.h
+++ b/libpostproc/postprocess.h
@@ -87,7 +87,9 @@ void pp_free_context(pp_context *ppContext);
 
 #define PP_CPU_CAPS_MMX   0x80000000
 #define PP_CPU_CAPS_MMX2  0x20000000
+#if FF_POSTPROC_AMD_3DNOW
 #define PP_CPU_CAPS_3DNOW 0x40000000
+#endif
 #define PP_CPU_CAPS_ALTIVEC 0x10000000
 #define PP_CPU_CAPS_AUTO  0x00080000
 
diff --git a/libpostproc/version_major.h b/libpostproc/version_major.h
index b40b251a73..af1ccf8f4c 100644
--- a/libpostproc/version_major.h
+++ b/libpostproc/version_major.h
@@ -28,4 +28,6 @@
 
 #define LIBPOSTPROC_VERSION_MAJOR  59
 
+#define FF_POSTPROC_AMD_3DNOW      (LIBPOSTPROC_VERSION_MAJOR < 60)
+
 #endif /* POSTPROC_VERSION_MAJOR_H */
-- 
2.39.5

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] libpostproc: deprecate the AMD 3DNow! define

[Andreas Rheinhardt]

Sean McGovern:
> Hi,
> 
> 
> On Fri, Apr 11, 2025, 09:52 Sean McGovern <gseanmcg@gmail.com> wrote:
> 
>> It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f.
>> ---
>>  libpostproc/postprocess.h | 2 ++
>>  libpostproc/version.h     | 2 ++
>>  2 files changed, 4 insertions(+)
>>
>> diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
>> index 5decb7e8a9..7010c2b51b 100644
>> --- a/libpostproc/postprocess.h
>> +++ b/libpostproc/postprocess.h
>> @@ -87,7 +87,9 @@ void pp_free_context(pp_context *ppContext);
>>
>>  #define PP_CPU_CAPS_MMX   0x80000000
>>  #define PP_CPU_CAPS_MMX2  0x20000000
>> +#if PP_AMD_3DNOW
>>  #define PP_CPU_CAPS_3DNOW 0x40000000
>> +#endif
>>  #define PP_CPU_CAPS_ALTIVEC 0x10000000
>>  #define PP_CPU_CAPS_AUTO  0x00080000
>>
>> diff --git a/libpostproc/version.h b/libpostproc/version.h
>> index bcbdd210c4..5a272630bf 100644
>> --- a/libpostproc/version.h
>> +++ b/libpostproc/version.h
>> @@ -43,4 +43,6 @@
>>
>>  #define LIBPOSTPROC_IDENT       "postproc"
>> AV_STRINGIFY(LIBPOSTPROC_VERSION)
>>
>> +#define PP_AMD_3DNOW               (LIBPOSTPROC_VERSION_MAJOR < 60)

defines like PP_AMD_3DNOW are not part of the public API and therefore
use an FF_ prefix (actually FF_API_ prefix).

>> +
>>  #endif /* POSTPROC_VERSION_H */
>> --
>> 2.39.5
>>
> 
> Did I do this correctly this time?

You forgot the APIchanges entry as well as the minor version bump.

> 
> Also it seems a bit much to wait a year or more for this to be actually
> removed. Can it instead be keyed to the next minor bump, or is this against
> some guarantee we give our downstreams?
> 
Actually, you should bump minor with the deprecation. And yes, this is
against the API guarantee for our downstreams. See lavu/avutil.h.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v4] libpostproc: deprecate the AMD 3DNow! define

[Sean McGovern]

It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f.
---
 doc/APIchanges              | 3 +++
 libpostproc/postprocess.h   | 2 ++
 libpostproc/version.h       | 2 +-
 libpostproc/version_major.h | 2 ++
 4 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/doc/APIchanges b/doc/APIchanges
index 65bf5a9419..2236ee1a88 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -2,6 +2,9 @@ The last version increases of all libraries were on 2025-03-28
 
 API changes, most recent first:
 
+2025-04-xx - ?????????? - libpostproc 59.0.101 - postprocess.h
+  Deprecate PP_CPU_CAPS_3DNOW.
+
 2025-04-07 - 19e9a203b7 - lavu 60.01.100 - dict.h
   Add AV_DICT_DEDUP.
 
diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
index 5decb7e8a9..d2adb6ccad 100644
--- a/libpostproc/postprocess.h
+++ b/libpostproc/postprocess.h
@@ -87,7 +87,9 @@ void pp_free_context(pp_context *ppContext);
 
 #define PP_CPU_CAPS_MMX   0x80000000
 #define PP_CPU_CAPS_MMX2  0x20000000
+#if FF_API_PP_AMD_3DNOW
 #define PP_CPU_CAPS_3DNOW 0x40000000
+#endif
 #define PP_CPU_CAPS_ALTIVEC 0x10000000
 #define PP_CPU_CAPS_AUTO  0x00080000
 
diff --git a/libpostproc/version.h b/libpostproc/version.h
index bcbdd210c4..de09db989f 100644
--- a/libpostproc/version.h
+++ b/libpostproc/version.h
@@ -31,7 +31,7 @@
 #include "version_major.h"
 
 #define LIBPOSTPROC_VERSION_MINOR   0
-#define LIBPOSTPROC_VERSION_MICRO 100
+#define LIBPOSTPROC_VERSION_MICRO 101
 
 #define LIBPOSTPROC_VERSION_INT AV_VERSION_INT(LIBPOSTPROC_VERSION_MAJOR, \
                                                LIBPOSTPROC_VERSION_MINOR, \
diff --git a/libpostproc/version_major.h b/libpostproc/version_major.h
index b40b251a73..b9946912db 100644
--- a/libpostproc/version_major.h
+++ b/libpostproc/version_major.h
@@ -28,4 +28,6 @@
 
 #define LIBPOSTPROC_VERSION_MAJOR  59
 
+#define FF_API_PP_AMD_3DNOW      (LIBPOSTPROC_VERSION_MAJOR < 60)
+
 #endif /* POSTPROC_VERSION_MAJOR_H */
-- 
2.39.5

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v4] libpostproc: deprecate the AMD 3DNow! define

[Andreas Rheinhardt]

Sean McGovern:
> It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f.
> ---
>  doc/APIchanges              | 3 +++
>  libpostproc/postprocess.h   | 2 ++
>  libpostproc/version.h       | 2 +-
>  libpostproc/version_major.h | 2 ++
>  4 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 65bf5a9419..2236ee1a88 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2025-03-28
>  
>  API changes, most recent first:
>  
> +2025-04-xx - ?????????? - libpostproc 59.0.101 - postprocess.h
> +  Deprecate PP_CPU_CAPS_3DNOW.
> +
>  2025-04-07 - 19e9a203b7 - lavu 60.01.100 - dict.h
>    Add AV_DICT_DEDUP.
>  
> diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
> index 5decb7e8a9..d2adb6ccad 100644
> --- a/libpostproc/postprocess.h
> +++ b/libpostproc/postprocess.h
> @@ -87,7 +87,9 @@ void pp_free_context(pp_context *ppContext);
>  
>  #define PP_CPU_CAPS_MMX   0x80000000
>  #define PP_CPU_CAPS_MMX2  0x20000000
> +#if FF_API_PP_AMD_3DNOW
>  #define PP_CPU_CAPS_3DNOW 0x40000000
> +#endif
>  #define PP_CPU_CAPS_ALTIVEC 0x10000000
>  #define PP_CPU_CAPS_AUTO  0x00080000
>  
> diff --git a/libpostproc/version.h b/libpostproc/version.h
> index bcbdd210c4..de09db989f 100644
> --- a/libpostproc/version.h
> +++ b/libpostproc/version.h
> @@ -31,7 +31,7 @@
>  #include "version_major.h"
>  
>  #define LIBPOSTPROC_VERSION_MINOR   0
> -#define LIBPOSTPROC_VERSION_MICRO 100
> +#define LIBPOSTPROC_VERSION_MICRO 101

minor, not micro

>  
>  #define LIBPOSTPROC_VERSION_INT AV_VERSION_INT(LIBPOSTPROC_VERSION_MAJOR, \
>                                                 LIBPOSTPROC_VERSION_MINOR, \
> diff --git a/libpostproc/version_major.h b/libpostproc/version_major.h
> index b40b251a73..b9946912db 100644
> --- a/libpostproc/version_major.h
> +++ b/libpostproc/version_major.h
> @@ -28,4 +28,6 @@
>  
>  #define LIBPOSTPROC_VERSION_MAJOR  59
>  
> +#define FF_API_PP_AMD_3DNOW      (LIBPOSTPROC_VERSION_MAJOR < 60)
> +
>  #endif /* POSTPROC_VERSION_MAJOR_H */

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".