From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 7A7DC4C1FE for <ffmpegdev@gitmailbox.com>; Mon, 7 Apr 2025 12:35:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EF468687D25; Mon, 7 Apr 2025 15:35:21 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E5918687C7B for <ffmpeg-devel@ffmpeg.org>; Mon, 7 Apr 2025 15:35:14 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id F046F44278 for <ffmpeg-devel@ffmpeg.org>; Mon, 7 Apr 2025 12:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1744029314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3U9fv7GMc7B35T+znltLZBstTwTr3PWHjBYOJ9EJtr8=; b=jFX3cfaEmlHyxJz4bSKu9NLcad2aIwBV4p07AhR+8A/6gSd+Wp4Po7Ht6M1DUG12QvY9tI uazyFCbxAo7ib9/rzt3P7gW1AwG2KUhzOZ/gSZoOSl8ZQjWx+KDL/Fh7CvGKg63FmxUhIi 61TNZC3EeiZVV5wDbJSyQYqdzZp2bTOZRP66wmWMbmAOJnCb4xb45HeNCtIqhhAbCF7l9T X1uTE2PhwZridy8qx1rqtB3hqA6pIgqqD69+94NmanH+a9JncGM6cj7NY+SJpiD2EYpQQ4 L+XDpCGOS8jW5GbnjMj0GG2vON1Y/aTTh4vq00H/D5j1cMMhd5RwQOHynF65Lg== Date: Mon, 7 Apr 2025 14:35:12 +0200 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20250407123512.GM4991@pb2> References: <20250403105049.883948-1-michael@niedermayer.cc> <20250403105049.883948-4-michael@niedermayer.cc> <cfa3f9f9-ef74-450b-96d1-bd40dabc8bbe@gmail.com> <20250406234412.GL4991@pb2> <c3041a79-8d7b-4c2d-aacb-760e7872f059@gmail.com> MIME-Version: 1.0 In-Reply-To: <c3041a79-8d7b-4c2d-aacb-760e7872f059@gmail.com> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvtddtvdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/4] avcodec/ffv1enc: avoid slices larger than 360x288 if no value is specified X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============5519610293541224983==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250407123512.GM4991@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============5519610293541224983== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wXAeeZJnodW56pfA" Content-Disposition: inline --wXAeeZJnodW56pfA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 06, 2025 at 10:13:23PM -0300, James Almer wrote: > On 4/6/2025 8:44 PM, Michael Niedermayer wrote: > > On Sun, Apr 06, 2025 at 08:29:42PM -0300, James Almer wrote: > > > On 4/3/2025 7:50 AM, Michael Niedermayer wrote: > > > > This improves speed by providing more independent things for more C= PUs > > > >=20 > > > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > > > --- > > > > libavcodec/ffv1enc.c | 6 +++++- > > > > .../ref/fate/matroska-mastering-display-metadata | 16 ++++++++--= ------ > > > > 2 files changed, 13 insertions(+), 9 deletions(-) > > > >=20 > > > > diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c > > > > index ce3f8e023e5..221344794e2 100644 > > > > --- a/libavcodec/ffv1enc.c > > > > +++ b/libavcodec/ffv1enc.c > > > > @@ -581,7 +581,11 @@ int ff_ffv1_encode_determine_slices(AVCodecCon= text *avctx) > > > > if ( ff_need_new_slices(avctx->width , s->num_h= _slices, s->chroma_h_shift) > > > > ||ff_need_new_slices(avctx->height, s->num_v= _slices, s->chroma_v_shift)) > > > > continue; > > > > - if (avctx->slices =3D=3D s->num_h_slices * s->num_v_sl= ices && avctx->slices <=3D MAX_SLICES || !avctx->slices) > > > > + if (avctx->slices =3D=3D s->num_h_slices * s->num_v_sl= ices && avctx->slices <=3D MAX_SLICES) > > > > + return 0; > > > > + if (maxw*maxh > 360*288) > > > > + continue; > > > > + if (!avctx->slices) > > > > return 0; > > > > } > > > > } > > > > diff --git a/tests/ref/fate/matroska-mastering-display-metadata b/t= ests/ref/fate/matroska-mastering-display-metadata > > > > index 91ce6a05584..6a2ff15b1b2 100644 > > > > --- a/tests/ref/fate/matroska-mastering-display-metadata > > > > +++ b/tests/ref/fate/matroska-mastering-display-metadata > > > > @@ -1,7 +1,7 @@ > > > > -ad5e3c4e338599c81ef7d0f9ae25f871 *tests/data/fate/matroska-masteri= ng-display-metadata.matroska > > > > -1669589 tests/data/fate/matroska-mastering-display-metadata.matros= ka > > > > +c1e5e2ecf433cf05af8556debc7d4d0b *tests/data/fate/matroska-masteri= ng-display-metadata.matroska > > > > +1669773 tests/data/fate/matroska-mastering-display-metadata.matros= ka > > > > #extradata 0: 4, 0x040901a3 > > > > -#extradata 3: 200, 0x506463a8 > > > > +#extradata 3: 202, 0xfce96279 > > >=20 > > > Why did extradata change? Slice dimension value changes? > >=20 > > yes, any reason you belive theres an issue ? >=20 > No, just wanted to know why the size of extradata changed. yes, 1280x720 used 2x2 slice configuration before and now uses 3x3 2x2 is stored as storing the value 1 twice and 3x3 stores the value 2 twice thats 4 range coded binary values more in the bitstream. Its a bit surprising that these end up needing 2 bytes more though but its possible if most of the other stuff is "1" and not "2" values than the cost of storing a "2" can be higher thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Never trust a computer, one day, it may think you are the virus. -- Compn --wXAeeZJnodW56pfA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ/PGeQAKCRBhHseHBAsP q781AJ4vHYy+mRMMCmAA8uixOezHb6N8LwCfUHG6t/z/wFV7jj4DzGWxzlwpLN4= =wCQt -----END PGP SIGNATURE----- --wXAeeZJnodW56pfA-- --===============5519610293541224983== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5519610293541224983==--