From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v10 1/8] libavcodec/decode.c: intercept `AV_PKT_DATA_METADATA_UPDATE` packet extra data, attach them to the next decoded frame with the same PTS.
Date: Fri, 4 Apr 2025 23:24:37 +0200
Message-ID: <20250404212437.GA4991@pb2> (raw)
In-Reply-To: <CABWZ6OST7Dfj70ef+SNvNtfw_Qa55hKzigk4a+675dZn8CjgXg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1328 bytes --]
On Fri, Apr 04, 2025 at 03:56:19PM -0500, Romain Beauxis wrote:
> Le ven. 4 avr. 2025 à 15:39, Michael Niedermayer
> <michael@niedermayer.cc> a écrit :
> >
> > Hi Romain
> >
> > On Wed, Apr 02, 2025 at 01:29:33PM -0500, Romain Beauxis wrote:
> > > ---
> > > libavcodec/decode.c | 130 ++++++++++++++++++++++++++++++++++++++++++++
> > > 1 file changed, 130 insertions(+)
> > >
> > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c
> > > index fca0c7ff58..b754ea13b6 100644
> > > --- a/libavcodec/decode.c
> > > +++ b/libavcodec/decode.c
> > [...]
> > > + // If node alrady exist, we update with the latest value.
> > > + if (ret && ret != pending) {
> > > + av_free(ret->data);
> > > + ret->data = pending->data;
> >
> > stray tab in indent, this cannot be pushed
>
> I'm confused.
sorry for confusing you
>
> You asked me to push the fixed patchset to a branch, which was done
> here: https://github.com/toots/FFmpeg/pull/2/commits/500f56ed270a4a6053ff51408f775a8b4be5210e
>
> Should I push a new version on here?
whatever you prefer, you can repost the patchset or post a link to your branch
to the mailing list
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
You can kill me, but you cannot change the truth.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-04-04 21:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 18:29 [FFmpeg-devel] [PATCH v10 0/8] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 1/8] libavcodec/decode.c: intercept `AV_PKT_DATA_METADATA_UPDATE` packet extra data, attach them to the next decoded frame with the same PTS Romain Beauxis
2025-04-04 20:39 ` Michael Niedermayer
2025-04-04 20:56 ` Romain Beauxis
2025-04-04 21:24 ` Michael Niedermayer [this message]
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 2/8] tests: Add stream dump test API util Romain Beauxis
2025-04-04 20:40 ` Michael Niedermayer
2025-04-04 20:55 ` Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 3/8] tests: Add chained ogg/vorbis stream dump test Romain Beauxis
2025-04-04 20:44 ` Michael Niedermayer
2025-04-04 20:53 ` Romain Beauxis
2025-04-04 21:00 ` Michael Niedermayer
2025-04-04 21:01 ` Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 4/8] libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 5/8] libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 6/8] tests: Add chained ogg/flac stream dump test Romain Beauxis
2025-04-04 20:45 ` Michael Niedermayer
2025-04-04 20:52 ` Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 7/8] libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 8/8] tests: Add chained ogg/opus stream dump test Romain Beauxis
2025-04-04 20:47 ` Michael Niedermayer
2025-04-04 20:53 ` Romain Beauxis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404212437.GA4991@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git