From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 607374C49D for <ffmpegdev@gitmailbox.com>; Fri, 4 Apr 2025 21:00:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ABF0868B6BE; Sat, 5 Apr 2025 00:00:10 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F412F687A90 for <ffmpeg-devel@ffmpeg.org>; Sat, 5 Apr 2025 00:00:03 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 583D144570 for <ffmpeg-devel@ffmpeg.org>; Fri, 4 Apr 2025 21:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1743800403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tdvpD8jn1cVR/Ep9CNWU921TYQeMA1F82HqgvmQCeuE=; b=Sppe/9QPBC3FzuV9FwLlyjgErRBNOuLRgCEk1WQyUjsDFm3cdeX+N+Ui8DSsEF8AzYa+zU kiDfBvv5C2b+2zNeTEGQohMCqzhlPlNyi+9CjTjaZYSECs5nylA30ZNTvnXXOHzZ+PEHTf 7qcBWmgF5maNYfq8S9JKA4idcSU7sqpQll/RsHBah0+VIUMfrdakDlrjZxHdczDB0Xmeou AWArmQeWj+A6dJo9wKBDG+rN+2AJwIQvoVXexEd4OwIj1ko8e0XcYjQ6B9mUdz32TQMmwK M38oQ9bDbbrMzMqvl9mwcHccQhiZ92WcRwAC1un4LLFP18kwuqmGwrT55tFTkg== Date: Fri, 4 Apr 2025 23:00:02 +0200 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20250404210002.GZ4991@pb2> References: <20250402182940.29726-1-romain.beauxis@gmail.com> <20250402182940.29726-4-romain.beauxis@gmail.com> <20250404204434.GW4991@pb2> <CABWZ6ORbhY93de4ECCSAkot8thQ055maACVCzB48CYS3Qp9FcQ@mail.gmail.com> MIME-Version: 1.0 In-Reply-To: <CABWZ6ORbhY93de4ECCSAkot8thQ055maACVCzB48CYS3Qp9FcQ@mail.gmail.com> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduledvgeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpedutedvhfduuedugedufefghefhvedvgffgffekhfdvgfdvtefftdejkeehteefheenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v10 3/8] tests: Add chained ogg/vorbis stream dump test. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============4561784450330087551==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250404210002.GZ4991@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============4561784450330087551== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="32kMyV3y+c8X0VBo" Content-Disposition: inline --32kMyV3y+c8X0VBo Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 04, 2025 at 03:53:14PM -0500, Romain Beauxis wrote: > Le ven. 4 avr. 2025 =E0 15:44, Michael Niedermayer > <michael@niedermayer.cc> a =E9crit : > > > > Hi Romain > > > > On Wed, Apr 02, 2025 at 01:29:35PM -0500, Romain Beauxis wrote: > > > --- > > > tests/Makefile | 1 + > > > tests/fate/ogg-vorbis.mak | 11 +++++++++++ > > > tests/ref/fate/ogg-vorbis-chained-meta.txt | 17 +++++++++++++++++ > > > 3 files changed, 29 insertions(+) > > > create mode 100644 tests/fate/ogg-vorbis.mak > > > create mode 100644 tests/ref/fate/ogg-vorbis-chained-meta.txt > > > > Applying: tests: Add chained ogg/vorbis stream dump test. > > .git/rebase-apply/patch:48: trailing whitespace. > > Stream ID: 0, frame PTS: 128, metadata: > > .git/rebase-apply/patch:50: trailing whitespace. > > Stream ID: 0, frame PTS: 704, metadata: > > .git/rebase-apply/patch:58: trailing whitespace. > > Stream ID: 0, frame PTS: 128, metadata: > > .git/rebase-apply/patch:60: trailing whitespace. > > Stream ID: 0, frame PTS: 704, metadata: > > warning: 4 lines add whitespace errors. > > > > do the tests pass without the trailing whitespace ? >=20 > I don't think it would. The text file is a dump from the command output. It passes here without the trailing whitespace I suggest to remove them, because some editors remove trailing whitespace some people git setups do too. It could cause pain to people if in c/h files trailing whitespace is forbidden but here its used. Also as this is ffmpeg output, maybe the code outputting trailing whitespace should be fixed thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart than the original author, trying to rewrite it will not make it better. --32kMyV3y+c8X0VBo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ/BITwAKCRBhHseHBAsP q16UAJ9dOFziYdCrSj64Nq8HRf2LWywYdACgm6lzdK9ZXaYicvgp+WFAvL+V64E= =y/ws -----END PGP SIGNATURE----- --32kMyV3y+c8X0VBo-- --===============4561784450330087551== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4561784450330087551==--