From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 304604BBC0 for <ffmpegdev@gitmailbox.com>; Wed, 2 Apr 2025 21:17:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4385268AB42; Thu, 3 Apr 2025 00:17:40 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 197E36879C1 for <ffmpeg-devel@ffmpeg.org>; Thu, 3 Apr 2025 00:17:33 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 796FC44396 for <ffmpeg-devel@ffmpeg.org>; Wed, 2 Apr 2025 21:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1743628652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xZGa9V5xVBF8CC8C5z+sZNhastYSgK8MULtSdwLcOf8=; b=RlVZo3iwfla9PqwNhRYYWoJxsphx6Q4wFeDZuVeuZuhmgOVwPH6mT2ChmQ8iIyUnk99aUZ XLDTLr7Yv4Kb7MWd0D/jHQ2FGgnK90wb30AdQLv84A5qNhUU/bxMsJaN+96gBG0VuZLVoh hTBnRn4hMMjyWmybgXBkJD1cKxF6WBMfnhL76vOOIf2xbdQfKJNR85AwBhYE8v6LECE+le 5oDYfsP72Af0/QcOgR+gvMXG1GJ67mI2R2NRKUHMvmM9NpB+KmNcrGIzlWKij3L5CrxUEr P5fHYdo++ohe6HrhAMpGFAllNeoal9hwhCeFujB3JlbI5+z78LywncSivy1+Og== Date: Wed, 2 Apr 2025 23:17:31 +0200 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20250402211731.GI4991@pb2> References: <20250402000358.483296-1-michael@niedermayer.cc> <97e8989-b5d4-df35-d1d2-703d2fd2b12a@martin.st> MIME-Version: 1.0 In-Reply-To: <97e8989-b5d4-df35-d1d2-703d2fd2b12a@martin.st> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddukeeijedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpedutedvhfduuedugedufefghefhvedvgffgffekhfdvgfdvtefftdejkeehteefheenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] tests/checkasm/checkasm.c: Assert that aligned_w/h do not overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============2998678872960238974==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250402211731.GI4991@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============2998678872960238974== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Zk0Bet+3F+4HY1+e" Content-Disposition: inline --Zk0Bet+3F+4HY1+e Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Martin On Wed, Apr 02, 2025 at 10:42:59AM +0300, Martin Storsj=F6 wrote: > On Wed, 2 Apr 2025, Michael Niedermayer wrote: >=20 > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > --- > > tests/checkasm/checkasm.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > >=20 > > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c > > index a5b862fe52e..1cfc4feb488 100644 > > --- a/tests/checkasm/checkasm.c > > +++ b/tests/checkasm/checkasm.c > > @@ -58,6 +58,7 @@ > > #include <stdlib.h> > > #include <string.h> > > #include "checkasm.h" > > +#include "libavutil/avassert.h" > > #include "libavutil/common.h" > > #include "libavutil/cpu.h" > > #include "libavutil/intfloat.h" > > @@ -1189,10 +1190,12 @@ int checkasm_check_##type(const char *file, int= line, \ > > int align_w, int align_h, \ > > int padding) \ > > { \ > > - int aligned_w =3D (w + align_w - 1) & ~(align_w - 1); \ > > - int aligned_h =3D (h + align_h - 1) & ~(align_h - 1); \ > > + int64_t aligned_w =3D (w - 1LL + align_w) & ~(align_w - 1); \ > > + int64_t aligned_h =3D (h - 1LL + align_h) & ~(align_h - 1); \ > > int err =3D 0; \ > > int y =3D 0; \ > > + av_assert0(aligned_w =3D=3D (int32_t)aligned_w);\ > > + av_assert0(aligned_h =3D=3D (int32_t)aligned_h);\ >=20 > Ok with me. will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire --Zk0Bet+3F+4HY1+e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ+2paAAKCRBhHseHBAsP q1uvAJ99OlWs4tlmBjp2LS1lVm6KvAcGGgCfTgTL5Z7iNZmq/p4HrCgI8yHa2Lk= =pa3r -----END PGP SIGNATURE----- --Zk0Bet+3F+4HY1+e-- --===============2998678872960238974== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2998678872960238974==--